Sishuai Gong 086629773e tracefs: Avoid changing i_mode to a temp value ... Right now inode->i_mode is updated twice to reach the desired value in tracefs_apply_options(). Because there is no lock protecting the two writes, other threads might read the intermediate value of inode->i_mode. Thread-1 Thread-2 // tracefs_apply_options() //e.g., acl_permission_check inode->i_mode &= ~S_IALLUGO; unsigned int mode = inode->i_mode; inode->i_mode |= opts->mode; I think there is no need to introduce a lock but it is better to only update inode->i_mode ONCE, so the readers will either see the old or latest value, rather than an intermediate/temporary value. Note, the race is not a security concern as the intermediate value is more locked down than either the start or end version. This is more just to do the conversion cleanly. Link: https://lore.kernel.org/linux-trace-kernel/AB5B0A1C-75D9-4E82-A7F0-CF7D0715587B@gmail.com Signed-off-by: Sishuai Gong <sishuai.system@gmail.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>		2023-08-22 05:23:53 -04:00
..
event_inode.c	eventfs: Implement removal of meta data from eventfs	2023-07-30 18:13:34 -04:00
inode.c	tracefs: Avoid changing i_mode to a temp value	2023-08-22 05:23:53 -04:00
internal.h	eventfs: Implement functions to create files and dirs when accessed	2023-07-30 18:13:34 -04:00
Makefile	eventfs: Implement eventfs dir creation functions	2023-07-30 18:13:33 -04:00