Binbin Zhou 70481755ed drivers/thermal/loongson2_thermal: Fix incorrect PTR_ERR() judgment ... [ Upstream commit 15ef92e9c4 ] PTR_ERR() returns -ENODEV when thermal-zones are undefined, and we need -ENODEV as the right value for comparison. Otherwise, tz->type is NULL when thermal-zones is undefined, resulting in the following error: [ 12.290030] CPU 1 Unable to handle kernel paging request at virtual address fffffffffffffff1, era == 900000000355f410, ra == 90000000031579b8 [ 12.302877] Oops[#1]: [ 12.305190] CPU: 1 PID: 181 Comm: systemd-udevd Not tainted 6.6.0-rc7+ #5385 [ 12.312304] pc 900000000355f410 ra 90000000031579b8 tp 90000001069e8000 sp 90000001069eba10 [ 12.320739] a0 0000000000000000 a1 fffffffffffffff1 a2 0000000000000014 a3 0000000000000001 [ 12.329173] a4 90000001069eb990 a5 0000000000000001 a6 0000000000001001 a7 900000010003431c [ 12.337606] t0 fffffffffffffff1 t1 54567fd5da9b4fd4 t2 900000010614ec40 t3 00000000000dc901 [ 12.346041] t4 0000000000000000 t5 0000000000000004 t6 900000010614ee20 t7 900000000d00b790 [ 12.354472] t8 00000000000dc901 u0 54567fd5da9b4fd4 s9 900000000402ae10 s0 900000010614ec40 [ 12.362916] s1 90000000039fced0 s2 ffffffffffffffed s3 ffffffffffffffed s4 9000000003acc000 [ 12.362931] s5 0000000000000004 s6 fffffffffffff000 s7 0000000000000490 s8 90000001028b2ec8 [ 12.362938] ra: 90000000031579b8 thermal_add_hwmon_sysfs+0x258/0x300 [ 12.386411] ERA: 900000000355f410 strscpy+0xf0/0x160 [ 12.391626] CRMD: 000000b0 (PLV0 -IE -DA +PG DACF=CC DACM=CC -WE) [ 12.397898] PRMD: 00000004 (PPLV0 +PIE -PWE) [ 12.403678] EUEN: 00000000 (-FPE -SXE -ASXE -BTE) [ 12.409859] ECFG: 00071c1c (LIE=2-4,10-12 VS=7) [ 12.415882] ESTAT: 00010000 [PIL] (IS= ECode=1 EsubCode=0) [ 12.415907] BADV: fffffffffffffff1 [ 12.415911] PRID: 0014a000 (Loongson-64bit, Loongson-2K1000) [ 12.415917] Modules linked in: loongson2_thermal(+) vfat fat uio_pdrv_genirq uio fuse zram zsmalloc [ 12.415950] Process systemd-udevd (pid: 181, threadinfo=00000000358b9718, task=00000000ace72fe3) [ 12.415961] Stack : 0000000000000dc0 54567fd5da9b4fd4 900000000402ae10 9000000002df9358 [ 12.415982] ffffffffffffffed 0000000000000004 9000000107a10aa8 90000001002a3410 [ 12.415999] ffffffffffffffed ffffffffffffffed 9000000107a11268 9000000003157ab0 [ 12.416016] 9000000107a10aa8 ffffff80020fc0c8 90000001002a3410 ffffffffffffffed [ 12.416032] 0000000000000024 ffffff80020cc1e8 900000000402b2a0 9000000003acc000 [ 12.416048] 90000001002a3410 0000000000000000 ffffff80020f4030 90000001002a3410 [ 12.416065] 0000000000000000 9000000002df6808 90000001002a3410 0000000000000000 [ 12.416081] ffffff80020f4030 0000000000000000 90000001002a3410 9000000002df2ba8 [ 12.416097] 00000000000000b4 90000001002a34f4 90000001002a3410 0000000000000002 [ 12.416114] ffffff80020f4030 fffffffffffffff0 90000001002a3410 9000000002df2f30 [ 12.416131] ... [ 12.416138] Call Trace: [ 12.416142] [<900000000355f410>] strscpy+0xf0/0x160 [ 12.416167] [<90000000031579b8>] thermal_add_hwmon_sysfs+0x258/0x300 [ 12.416183] [<9000000003157ab0>] devm_thermal_add_hwmon_sysfs+0x50/0xe0 [ 12.416200] [<ffffff80020cc1e8>] loongson2_thermal_probe+0x128/0x200 [loongson2_thermal] [ 12.416232] [<9000000002df6808>] platform_probe+0x68/0x140 [ 12.416249] [<9000000002df2ba8>] really_probe+0xc8/0x3c0 [ 12.416269] [<9000000002df2f30>] __driver_probe_device+0x90/0x180 [ 12.416286] [<9000000002df3058>] driver_probe_device+0x38/0x160 [ 12.416302] [<9000000002df33a8>] __driver_attach+0xa8/0x200 [ 12.416314] [<9000000002deffec>] bus_for_each_dev+0x8c/0x120 [ 12.416330] [<9000000002df198c>] bus_add_driver+0x10c/0x2a0 [ 12.416346] [<9000000002df46b4>] driver_register+0x74/0x160 [ 12.416358] [<90000000022201a4>] do_one_initcall+0x84/0x220 [ 12.416372] [<90000000022f3ab8>] do_init_module+0x58/0x2c0 [ 12.416386] [<90000000022f6538>] init_module_from_file+0x98/0x100 [ 12.416399] [<90000000022f67f0>] sys_finit_module+0x230/0x3c0 [ 12.416412] [<900000000358f7c8>] do_syscall+0x88/0xc0 [ 12.416431] [<900000000222137c>] handle_syscall+0xbc/0x158 Fixes: e7e3a7c357 ("thermal/drivers/loongson-2: Add thermal management support") Cc: Yinbo Zhu <zhuyinbo@loongson.cn> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/343c14de98216636a47b43e8bfd47b70d0a8e068.1700817227.git.zhoubinbin@loongson.cn Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-01-25 15:35:15 -08:00
..
broadcom	thermal/drivers/broadcom/brcstb_thermal: Removed unneeded platform_set_drvdata()	2023-08-16 12:22:28 +02:00
intel	thermal: intel: powerclamp: fix mismatch in get function for max_idle	2023-11-28 17:20:02 +00:00
mediatek	thermal/drivers/mediatek: Fix probe for THERMAL_V2	2023-11-20 11:59:01 +01:00
qcom	thermal/drivers/tsens: Make tsens_xxxx_nvmem static	2023-08-16 09:54:39 +02:00
samsung	thermal/drivers/samsung: Fix Wvoid-pointer-to-enum-cast warning	2023-08-16 12:11:19 +02:00
st	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
tegra	thermal/drivers/tegra-bpmp: Check if BPMP supports trip points	2023-08-22 19:10:28 +02:00
ti-soc-thermal	thermal: Constify the trip argument of the .get_trend() zone callback	2023-09-11 17:16:40 +02:00
amlogic_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
armada_thermal.c	thermal: Use thermal_tripless_zone_device_register()	2023-09-05 21:42:18 +02:00
cpufreq_cooling.c	- Add more thermal zone device encapsulation: prevent setting	2023-04-03 20:43:32 +02:00
cpuidle_cooling.c	More thermal control updates for 6.4-rc1	2023-05-03 11:46:01 -07:00
da9062-thermal.c	thermal/drivers/da9062: Don't access the thermal zone device fields	2023-03-03 20:45:03 +01:00
db8500_thermal.c	thermal/drivers/db8500: Remove redundant of_match_ptr()	2023-08-16 12:09:19 +02:00
devfreq_cooling.c	thermal/core: Relocate the traces definition in thermal directory	2023-04-01 20:51:45 +02:00
dove_thermal.c	thermal: Use thermal_tripless_zone_device_register()	2023-09-05 21:42:18 +02:00
gov_bang_bang.c	thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions	2023-01-06 14:14:47 +01:00
gov_fair_share.c	thermal/core: Relocate the traces definition in thermal directory	2023-04-01 20:51:45 +02:00
gov_power_allocator.c	thermal/core: Relocate the traces definition in thermal directory	2023-04-01 20:51:45 +02:00
gov_step_wise.c	thermal: gov_step_wise: Adjust code logic to match comment	2023-04-27 19:17:11 +02:00
gov_user_space.c
hisi_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
imx8mm_thermal.c	thermal/drivers/imx8mm: Suppress log message on probe deferral	2023-08-16 09:54:39 +02:00
imx_sc_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
imx_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
k3_bandgap.c	thermal/drivers/k3_bandgap: Remove unneeded call to platform_set_drvdata()	2023-08-16 12:19:28 +02:00
k3_j72xx_bandgap.c	thermal/drivers/k3_j72xx_bandgap: Removed unneeded call to platform_set_drvdata()	2023-08-16 12:18:02 +02:00
Kconfig	thermal/drivers/loongson-2: Add thermal management support	2023-08-17 09:27:18 +02:00
khadas_mcu_fan.c
kirkwood_thermal.c	thermal: Use thermal_tripless_zone_device_register()	2023-09-05 21:42:18 +02:00
loongson2_thermal.c	drivers/thermal/loongson2_thermal: Fix incorrect PTR_ERR() judgment	2024-01-25 15:35:15 -08:00
Makefile	thermal/drivers/loongson-2: Add thermal management support	2023-08-17 09:27:18 +02:00
max77620_thermal.c	thermal/drivers/max77620_thermal: Removed unneeded call to platform_set_drvdata()	2023-08-16 12:33:53 +02:00
qoriq_thermal.c	thermal/drivers/qoriq: Remove redundant msg in qoriq_tmu_register_tmu_zone()	2023-06-26 12:03:14 +02:00
rcar_gen3_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
rcar_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
rockchip_thermal.c	thermal/drivers/rockchip: use devm_reset_control_array_get_exclusive()	2023-04-07 10:31:33 +02:00
rzg2l_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
spear_thermal.c	thermal: Use thermal_tripless_zone_device_register()	2023-09-05 21:42:18 +02:00
sprd_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00
sun8i_thermal.c	thermal/drivers/sun8i_thermal: Remove unneeded call to platform_set_drvdata()	2023-08-16 12:31:22 +02:00
thermal_acpi.c	thermal: ACPI: Make helpers retrieve temperature only	2023-02-02 15:26:45 +01:00
thermal_core.c	thermal: core: Fix NULL pointer dereference in zone registration error path	2024-01-25 15:35:15 -08:00
thermal_core.h	thermal: core: Rework .get_trend() thermal zone callback	2023-08-29 20:48:35 +02:00
thermal_helpers.c	thermal: core: Rework .get_trend() thermal zone callback	2023-08-29 20:48:35 +02:00
thermal_hwmon.c	thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs()	2023-06-26 12:03:14 +02:00
thermal_hwmon.h	thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs()	2023-03-03 20:45:02 +01:00
thermal_mmio.c	thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers	2023-03-03 20:45:02 +01:00
thermal_netlink.c	thermal/core: Fix unregistering netlink at thermal init time	2023-01-25 16:40:39 +01:00
thermal_netlink.h	thermal/core: Fix unregistering netlink at thermal init time	2023-01-25 16:40:39 +01:00
thermal_of.c	thermal/of: add missing of_node_put()	2023-09-11 17:16:36 +02:00
thermal_sysfs.c	thermal: sysfs: Fix trip_point_hyst_store()	2023-09-18 13:13:05 +02:00
thermal_trace_ipa.h	thermal/core: Relocate the traces definition in thermal directory	2023-04-01 20:51:45 +02:00
thermal_trace.h	thermal/core: Relocate the traces definition in thermal directory	2023-04-01 20:51:45 +02:00
thermal_trip.c	thermal: core: Don't update trip points inside the hysteresis range	2023-11-20 11:59:01 +01:00
thermal-generic-adc.c	thermal/drivers/generic-adc: Removed unneeded call to platform_set_drvdata()	2023-08-16 12:36:21 +02:00
uniphier_thermal.c	thermal: Explicitly include correct DT includes	2023-07-31 20:03:42 +02:00