Josef Bacik 07d399cb4e btrfs: take the dio extent lock during O_DIRECT operations ... Currently we hold the extent lock for the entire duration of a read. This isn't really necessary in the buffered case, we're protected by the page lock, however it's necessary for O_DIRECT. For O_DIRECT reads, if we only locked the extent for the part where we get the extent, we could potentially race with an O_DIRECT write in the same region. This isn't really a problem, unless the read is delayed so much that the write does the COW, unpins the old extent, and some other application re-allocates the extent before the read is actually able to be submitted. At that point at best we'd have a checksum mismatch, but at worse we could read data that doesn't belong to us. To address this potential race we need to make sure we don't have overlapping, concurrent direct io reads and writes. To accomplish this use the new EXTENT_DIO_LOCKED bit in the direct IO case in the same spot as the current extent lock. The writes will take this while they're creating the ordered extent, which is also used to make sure concurrent buffered reads or concurrent direct reads are not allowed to occur, and drop it after the ordered extent is taken. For reads it will act as the current read behavior for the EXTENT_LOCKED bit, we set it when we're starting the read, we clear it in the end_io to allow other direct writes to continue. This still has the drawback of disallowing concurrent overlapping direct reads from occurring, but that exists with the current extent locking. Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2024-09-10 16:51:20 +02:00
..
tests	btrfs: convert find_lock_delalloc_range() to use a folio	2024-09-10 16:51:14 +02:00
accessors.c	btrfs: remove unused included headers	2024-03-04 16:24:46 +01:00
accessors.h	btrfs: remove raid-stripe-tree encoding field from stripe_extent	2024-07-11 15:33:28 +02:00
acl.c	btrfs: remove unused included headers	2024-03-04 16:24:46 +01:00
acl.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
async-thread.c	btrfs: remove unused included headers	2024-03-04 16:24:46 +01:00
async-thread.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
backref.c	btrfs: change root->root_key.objectid to btrfs_root_id()	2024-05-07 21:31:06 +02:00
backref.h	btrfs: uninline some static inline helpers from backref.h	2024-03-04 16:24:53 +01:00
bio.c	btrfs: rename __btrfs_submit_bio() and drop double underscores	2024-09-10 16:51:19 +02:00
bio.h	btrfs: rename btrfs_submit_bio() to btrfs_submit_bbio()	2024-09-10 16:51:19 +02:00
block-group.c	btrfs: zoned: fix zone_unusable accounting on making block group read-write again	2024-07-29 19:21:19 +02:00
block-group.h	btrfs: switch btrfs_block_group::inode to struct btrfs_inode	2024-07-11 15:33:28 +02:00
block-rsv.c	btrfs: change root->root_key.objectid to btrfs_root_id()	2024-05-07 21:31:06 +02:00
block-rsv.h	btrfs: add forward declarations and headers, part 2	2024-03-04 16:24:49 +01:00
btrfs_inode.h	btrfs: convert btrfs_get_extent() to take a folio	2024-09-10 16:51:16 +02:00
compression.c	btrfs: rename btrfs_submit_bio() to btrfs_submit_bbio()	2024-09-10 16:51:19 +02:00
compression.h	btrfs: pass a btrfs_inode to btrfs_compress_heuristic()	2024-07-11 15:33:28 +02:00
ctree.c	btrfs: fix data race when accessing the last_trans field of a root	2024-07-11 15:52:25 +02:00
ctree.h	btrfs: fix race between direct IO write and fsync when using same fd	2024-09-03 20:29:55 +02:00
defrag.c	btrfs: always pass readahead state to defrag	2024-09-10 16:51:20 +02:00
defrag.h	btrfs: drop transaction parameter from btrfs_add_inode_defrag()	2024-09-10 16:51:19 +02:00
delalloc-space.c	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
delalloc-space.h	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
delayed-inode.c	btrfs: pass a btrfs_inode to btrfs_readdir_get_delayed_items()	2024-07-11 15:33:28 +02:00
delayed-inode.h	btrfs: pass a btrfs_inode to btrfs_readdir_get_delayed_items()	2024-07-11 15:33:28 +02:00
delayed-ref.c	btrfs: qgroup: use xarray to track dirty extents in transaction	2024-09-10 16:51:18 +02:00
delayed-ref.h	btrfs: qgroup: use xarray to track dirty extents in transaction	2024-09-10 16:51:18 +02:00
dev-replace.c	btrfs: more efficient chunk map iteration when device replace finishes	2024-09-10 16:51:17 +02:00
dev-replace.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
dir-item.c	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
dir-item.h	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
direct-io.c	btrfs: take the dio extent lock during O_DIRECT operations	2024-09-10 16:51:20 +02:00
direct-io.h	btrfs: move the direct IO code into its own file	2024-07-11 15:33:29 +02:00
discard.c	btrfs: unexport btrfs_run_discard_work and make it static	2023-06-19 13:59:25 +02:00
discard.h	btrfs: unexport btrfs_run_discard_work and make it static	2023-06-19 13:59:25 +02:00
disk-io.c	btrfs: subpage: remove btrfs_fs_info::subpage_info member	2024-09-10 16:51:18 +02:00
disk-io.h	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
export.c	btrfs: remove super block argument from btrfs_iget()	2024-07-11 15:33:25 +02:00
export.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
extent_io.c	btrfs: rename __extent_writepage() and drop double underscores	2024-09-10 16:51:19 +02:00
extent_io.h	btrfs: convert extent_write_locked_range() to take a folio	2024-09-10 16:51:15 +02:00
extent_map.c	btrfs: reduce size and overhead of extent_map_block_end()	2024-09-10 16:51:12 +02:00
extent_map.h	btrfs: do not directly include rwlock_types.h	2024-07-11 15:33:22 +02:00
extent-io-tree.c	btrfs: introduce EXTENT_DIO_LOCKED	2024-09-10 16:51:20 +02:00
extent-io-tree.h	btrfs: introduce EXTENT_DIO_LOCKED	2024-09-10 16:51:20 +02:00
extent-tree.c	btrfs: check delayed refs when we're checking if a ref exists	2024-08-13 13:42:26 +02:00
extent-tree.h	btrfs: do not BUG_ON() when freeing tree block after error	2024-07-11 15:33:26 +02:00
fiemap.c	btrfs: initialize last_extent_end to fix -Wmaybe-uninitialized warning in extent_fiemap()	2024-08-26 16:58:13 +02:00
fiemap.h	btrfs: move fiemap code into its own file	2024-07-11 15:33:20 +02:00
file-item.c	btrfs: introduce new "rescue=ignoremetacsums" mount option	2024-07-11 15:33:29 +02:00
file-item.h	btrfs: remove search_commit parameter from btrfs_lookup_csums_list()	2024-05-07 21:31:03 +02:00
file.c	btrfs: utilize folio more in btrfs_page_mkwrite()	2024-09-10 16:51:14 +02:00
file.h	btrfs: move the direct IO code into its own file	2024-07-11 15:33:29 +02:00
free-space-cache.c	btrfs: zoned: properly take lock to read/update block group's zoned variables	2024-08-15 20:35:56 +02:00
free-space-cache.h	btrfs: add forward declarations and headers, part 2	2024-03-04 16:24:49 +01:00
free-space-tree.c	btrfs: do not BUG_ON() when freeing tree block after error	2024-07-11 15:33:26 +02:00
free-space-tree.h	btrfs: add forward declarations and headers, part 2	2024-03-04 16:24:49 +01:00
fs.c
fs.h	btrfs: subpage: remove btrfs_fs_info::subpage_info member	2024-09-10 16:51:18 +02:00
inode-item.c	btrfs: abort transaction if we don't find extref in btrfs_del_inode_extref()	2024-07-11 15:33:27 +02:00
inode-item.h	btrfs: add forward declarations and headers, part 2	2024-03-04 16:24:49 +01:00
inode.c	btrfs: drop transaction parameter from btrfs_add_inode_defrag()	2024-09-10 16:51:19 +02:00
ioctl.c	btrfs: directly wake up cleaner kthread in the BTRFS_IOC_SYNC ioctl	2024-09-10 16:51:18 +02:00
ioctl.h	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
Kconfig	btrfs: check-integrity: remove CONFIG_BTRFS_FS_CHECK_INTEGRITY option	2023-10-12 16:44:05 +02:00
locking.c	btrfs: change root->root_key.objectid to btrfs_root_id()	2024-05-07 21:31:06 +02:00
locking.h	btrfs: cleanup recursive include of the same header	2024-07-11 15:33:22 +02:00
lru_cache.c	btrfs: fix typos found by codespell	2023-12-15 23:00:04 +01:00
lru_cache.h	btrfs: cleanup recursive include of the same header	2024-07-11 15:33:22 +02:00
lzo.c	btrfs: enhance compression error messages	2024-07-11 15:52:25 +02:00
Makefile	btrfs: move the direct IO code into its own file	2024-07-11 15:33:29 +02:00
messages.c	btrfs: introduce new "rescue=ignoremetacsums" mount option	2024-07-11 15:33:29 +02:00
messages.h	btrfs: constify fs_info parameter in __btrfs_panic()	2023-12-15 20:27:02 +01:00
misc.h	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
ordered-data.c	btrfs: convert btrfs_mark_ordered_io_finished() to take a folio	2024-09-10 16:51:14 +02:00
ordered-data.h	btrfs: convert btrfs_mark_ordered_io_finished() to take a folio	2024-09-10 16:51:14 +02:00
orphan.c	btrfs: remove unused included headers	2024-03-04 16:24:46 +01:00
orphan.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
print-tree.c	btrfs: avoid using fixed char array size for tree names	2024-08-02 22:44:27 +02:00
print-tree.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
props.c	btrfs: pass a btrfs_inode to btrfs_set_prop()	2024-07-11 15:33:29 +02:00
props.h	btrfs: pass a btrfs_inode to btrfs_set_prop()	2024-07-11 15:33:29 +02:00
qgroup.c	btrfs: qgroup: use xarray to track dirty extents in transaction	2024-09-10 16:51:18 +02:00
qgroup.h	btrfs: qgroup: use xarray to track dirty extents in transaction	2024-09-10 16:51:18 +02:00
raid56.c	btrfs: rename the extra_gfp parameter of btrfs_alloc_page_array()	2024-07-11 15:33:30 +02:00
raid56.h	btrfs: add forward declarations and headers, part 2	2024-03-04 16:24:49 +01:00
raid-stripe-tree.c	btrfs: change RST lookup error message level to debug	2024-09-10 16:51:17 +02:00
raid-stripe-tree.h	btrfs: remove raid-stripe-tree encoding field from stripe_extent	2024-07-11 15:33:28 +02:00
rcu-string.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
ref-verify.c	btrfs: fix uninitialized return value in the ref-verify tool	2024-07-02 19:14:57 +02:00
ref-verify.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
reflink.c	btrfs: pass a btrfs_inode to btrfs_wait_ordered_range()	2024-07-11 15:33:18 +02:00
reflink.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
relocation.c	btrfs: don't readahead the relocation inode on RST	2024-09-10 16:51:17 +02:00
relocation.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
root-tree.c	btrfs: change root->root_key.objectid to btrfs_root_id()	2024-05-07 21:31:06 +02:00
root-tree.h	btrfs: qgroup: fix qgroup prealloc rsv leak in subvolume operations	2024-04-02 19:18:23 +02:00
scrub.c	btrfs: rename btrfs_submit_bio() to btrfs_submit_bbio()	2024-09-10 16:51:19 +02:00
scrub.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
send.c	btrfs: send: fix grammar in comments	2024-09-10 16:51:18 +02:00
send.h	btrfs: pass a btrfs_inode to btrfs_ioctl_send()	2024-07-11 15:33:28 +02:00
space-info.c	btrfs: fix uninitialized return value from btrfs_reclaim_sweep()	2024-08-27 16:42:09 +02:00
space-info.h	btrfs: fix uninitialized return value from btrfs_reclaim_sweep()	2024-08-27 16:42:09 +02:00
subpage.c	btrfs: rename __extent_writepage() and drop double underscores	2024-09-10 16:51:19 +02:00
subpage.h	btrfs: subpage: remove btrfs_fs_info::subpage_info member	2024-09-10 16:51:18 +02:00
super.c	btrfs: only enable extent map shrinker for DEBUG builds	2024-08-16 21:22:39 +02:00
super.h	btrfs: change BTRFS_MOUNT_* flags to 64bit type	2024-07-19 17:20:23 +02:00
sysfs.c	btrfs: introduce new "rescue=ignoresuperflags" mount option	2024-07-11 15:33:30 +02:00
sysfs.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
transaction.c	btrfs: qgroup: use xarray to track dirty extents in transaction	2024-09-10 16:51:18 +02:00
transaction.h	btrfs: fix race between direct IO write and fsync when using same fd	2024-09-03 20:29:55 +02:00
tree-checker.c	btrfs: tree-checker: add dev extent item checks	2024-08-15 20:35:52 +02:00
tree-checker.h	btrfs: make sure that WRITTEN is set on all metadata blocks	2024-05-02 22:11:13 +02:00
tree-log.c	btrfs: remove super block argument from btrfs_iget()	2024-07-11 15:33:25 +02:00
tree-log.h	btrfs: avoid transaction commit on any fsync after subvolume creation	2024-07-11 15:33:24 +02:00
tree-mod-log.c	btrfs: change root->root_key.objectid to btrfs_root_id()	2024-05-07 21:31:06 +02:00
tree-mod-log.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
ulist.c	btrfs: preallocate ulist memory for qgroup rsv	2024-07-11 15:33:26 +02:00
ulist.h	btrfs: preallocate ulist memory for qgroup rsv	2024-07-11 15:33:26 +02:00
uuid-tree.c	btrfs: move uuid tree related code to uuid-tree.[ch]	2024-09-10 16:51:12 +02:00
uuid-tree.h	btrfs: move uuid tree related code to uuid-tree.[ch]	2024-09-10 16:51:12 +02:00
verity.c	btrfs: remove unused included headers	2024-03-04 16:24:46 +01:00
verity.h	btrfs: add forward declarations and headers, part 1	2024-03-04 16:24:49 +01:00
volumes.c	btrfs: reduce chunk_map lookups in btrfs_map_block()	2024-09-10 16:51:18 +02:00
volumes.h	btrfs: rename btrfs_io_stripe::is_scrub to rst_search_commit_root	2024-09-10 16:51:17 +02:00
xattr.c	btrfs: pass a btrfs_inode to btrfs_set_prop()	2024-07-11 15:33:29 +02:00
xattr.h	btrfs: constify pointer parameters where applicable	2024-07-11 15:33:22 +02:00
zlib.c	btrfs: enhance compression error messages	2024-07-11 15:52:25 +02:00
zoned.c	btrfs: zoned: handle broken write pointer on zones	2024-09-02 23:39:34 +02:00
zoned.h	btrfs: change BTRFS_MOUNT_* flags to 64bit type	2024-07-19 17:20:23 +02:00
zstd.c	btrfs: enhance compression error messages	2024-07-11 15:52:25 +02:00