mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-27 13:05:03 +08:00
fcd70cd36b
Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_helper.h includes. v2: Make it compile. There was so much compile fail on arm drivers that I figured I'll better not include any of the acks on v1. v3: Massive rebase because i915 has lost a lot of drmP.h includes, but not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h there was still one, which this patch largely removes. Which means rolling out lots more includes all over. This will also conflict with ongoing drmP.h cleanup by others I expect. v3: Rebase on top of atomic bochs. v4: Review from Laurent for bridge/rcar/omap/shmob/core bits: - (re)move some of the added includes, use the better include files in other places (all suggested from Laurent adopted unchanged). - sort alphabetically v5: Actually try to sort them, and while at it, sort all the ones I touch. v6: Rebase onto i915 changes. v7: Rebase once more. Acked-by: Harry Wentland <harry.wentland@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Acked-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Acked-by: CK Hu <ck.hu@mediatek.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: linux-arm-kernel@lists.infradead.org Cc: virtualization@lists.linux-foundation.org Cc: etnaviv@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: linux-mediatek@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: spice-devel@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-tegra@vger.kernel.org Cc: xen-devel@lists.xen.org Link: https://patchwork.freedesktop.org/patch/msgid/20190117210334.13234-1-daniel.vetter@ffwll.ch
106 lines
2.5 KiB
C
106 lines
2.5 KiB
C
/*
|
|
* Copyright (C) 2012 Russell King
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* Armada 510 (aka Dove) variant support
|
|
*/
|
|
#include <linux/clk.h>
|
|
#include <linux/io.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include "armada_crtc.h"
|
|
#include "armada_drm.h"
|
|
#include "armada_hw.h"
|
|
|
|
static int armada510_crtc_init(struct armada_crtc *dcrtc, struct device *dev)
|
|
{
|
|
struct clk *clk;
|
|
|
|
clk = devm_clk_get(dev, "ext_ref_clk1");
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk) == -ENOENT ? -EPROBE_DEFER : PTR_ERR(clk);
|
|
|
|
dcrtc->extclk[0] = clk;
|
|
|
|
/* Lower the watermark so to eliminate jitter at higher bandwidths */
|
|
armada_updatel(0x20, (1 << 11) | 0xff, dcrtc->base + LCD_CFG_RDREG4F);
|
|
|
|
/* Initialise SPU register */
|
|
writel_relaxed(ADV_HWC32ENABLE | ADV_HWC32ARGB | ADV_HWC32BLEND,
|
|
dcrtc->base + LCD_SPU_ADV_REG);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Armada510 specific SCLK register selection.
|
|
* This gets called with sclk = NULL to test whether the mode is
|
|
* supportable, and again with sclk != NULL to set the clocks up for
|
|
* that. The former can return an error, but the latter is expected
|
|
* not to.
|
|
*
|
|
* We currently are pretty rudimentary here, always selecting
|
|
* EXT_REF_CLK_1 for LCD0 and erroring LCD1. This needs improvement!
|
|
*/
|
|
static int armada510_crtc_compute_clock(struct armada_crtc *dcrtc,
|
|
const struct drm_display_mode *mode, uint32_t *sclk)
|
|
{
|
|
struct clk *clk = dcrtc->extclk[0];
|
|
int ret;
|
|
|
|
if (dcrtc->num == 1)
|
|
return -EINVAL;
|
|
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
if (dcrtc->clk != clk) {
|
|
ret = clk_prepare_enable(clk);
|
|
if (ret)
|
|
return ret;
|
|
dcrtc->clk = clk;
|
|
}
|
|
|
|
if (sclk) {
|
|
uint32_t rate, ref, div;
|
|
|
|
rate = mode->clock * 1000;
|
|
ref = clk_round_rate(clk, rate);
|
|
div = DIV_ROUND_UP(ref, rate);
|
|
if (div < 1)
|
|
div = 1;
|
|
|
|
clk_set_rate(clk, ref);
|
|
*sclk = div | SCLK_510_EXTCLK1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void armada510_crtc_disable(struct armada_crtc *dcrtc)
|
|
{
|
|
if (!IS_ERR(dcrtc->clk)) {
|
|
clk_disable_unprepare(dcrtc->clk);
|
|
dcrtc->clk = ERR_PTR(-EINVAL);
|
|
}
|
|
}
|
|
|
|
static void armada510_crtc_enable(struct armada_crtc *dcrtc,
|
|
const struct drm_display_mode *mode)
|
|
{
|
|
if (IS_ERR(dcrtc->clk)) {
|
|
dcrtc->clk = dcrtc->extclk[0];
|
|
WARN_ON(clk_prepare_enable(dcrtc->clk));
|
|
}
|
|
}
|
|
|
|
const struct armada_variant armada510_ops = {
|
|
.has_spu_adv_reg = true,
|
|
.init = armada510_crtc_init,
|
|
.compute_clock = armada510_crtc_compute_clock,
|
|
.disable = armada510_crtc_disable,
|
|
.enable = armada510_crtc_enable,
|
|
};
|