Thomas Gleixner 0303c9729a x86/efi: Make efi_set_virtual_address_map IBT safe ... Niklāvs reported a boot regression on an Alderlake machine and bisected it to commit 9df9d2f047 ("init: Invoke arch_cpu_finalize_init() earlier"). By moving the invocation of arch_cpu_finalize_init() further down he identified that efi_enter_virtual_mode() is the function which causes the boot hang. The main difference of the earlier invocation is that the boot CPU is already fully initialized and mitigations and alternatives are applied. But the only really interesting change turned out to be IBT, which is now enabled before efi_enter_virtual_mode(). "ibt=off" on the kernel command line cured the problem. Inspection of the involved calls in efi_enter_virtual_mode() unearthed that efi_set_virtual_address_map() is the only place in the kernel which invokes an EFI call without the IBT safe wrapper. This went obviously unnoticed so far as IBT was enabled later. Use arch_efi_call_virt() instead of efi_call() to cure that. Fixes: fe379fa4d1 ("x86/ibt: Disable IBT around firmware") Fixes: 9df9d2f047 ("init: Invoke arch_cpu_finalize_init() earlier") Reported-by: Niklāvs Koļesņikovs <pinkflames.linux@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217602 Link: https://lore.kernel.org/r/87jzvm12q0.ffs@tglx		2023-06-30 15:26:24 +02:00
..
efi_32.c	efi/x86: Move 32-bit code into efi_32.c	2020-08-20 11:18:36 +02:00
efi_64.c	x86/efi: Make efi_set_virtual_address_map IBT safe	2023-06-30 15:26:24 +02:00
efi_stub_32.S	x86: Prepare asm files for straight-line-speculation	2021-12-08 12:25:37 +01:00
efi_stub_64.S	x86: Prepare asm files for straight-line-speculation	2021-12-08 12:25:37 +01:00
efi_thunk_64.S	efi/x86-mixed: move unmitigated RET into .rodata	2022-08-16 09:28:05 +02:00
efi.c	efi: Drop minimum EFI version check at boot	2023-02-03 18:01:07 +01:00
fake_mem.c	efi: memmap: Move EFI fake memmap support into x86 arch tree	2022-11-18 09:14:09 +01:00
Makefile	efi: x86: Move EFI runtime map sysfs code to arch/x86	2022-11-18 09:14:09 +01:00
memmap.c	efi: xen: Set EFI_PARAVIRT for Xen dom0 boot on all architectures	2022-11-18 09:14:09 +01:00
quirks.c	x86/sme: Explicitly map new EFI memmap table as encrypted	2021-12-05 16:44:52 +01:00
runtime-map.c	efi: x86: Move EFI runtime map sysfs code to arch/x86	2022-11-18 09:14:09 +01:00