Markus Weippert 0c7fa41e3e bcache: revert replacing IS_ERR_OR_NULL with IS_ERR ... commit bb6cc25386 upstream. Commit 028ddcac47 ("bcache: Remove unnecessary NULL point check in node allocations") replaced IS_ERR_OR_NULL by IS_ERR. This leads to a NULL pointer dereference. BUG: kernel NULL pointer dereference, address: 0000000000000080 Call Trace: ? __die_body.cold+0x1a/0x1f ? page_fault_oops+0xd2/0x2b0 ? exc_page_fault+0x70/0x170 ? asm_exc_page_fault+0x22/0x30 ? btree_node_free+0xf/0x160 [bcache] ? up_write+0x32/0x60 btree_gc_coalesce+0x2aa/0x890 [bcache] ? bch_extent_bad+0x70/0x170 [bcache] btree_gc_recurse+0x130/0x390 [bcache] ? btree_gc_mark_node+0x72/0x230 [bcache] bch_btree_gc+0x5da/0x600 [bcache] ? cpuusage_read+0x10/0x10 ? bch_btree_gc+0x600/0x600 [bcache] bch_gc_thread+0x135/0x180 [bcache] The relevant code starts with: new_nodes[0] = NULL; for (i = 0; i < nodes; i++) { if (__bch_keylist_realloc(&keylist, bkey_u64s(&r[i].b->key))) goto out_nocoalesce; // ... out_nocoalesce: // ... for (i = 0; i < nodes; i++) if (!IS_ERR(new_nodes[i])) { // IS_ERR_OR_NULL before 028ddcac47 btree_node_free(new_nodes[i]); // new_nodes[0] is NULL rw_unlock(true, new_nodes[i]); } This patch replaces IS_ERR() by IS_ERR_OR_NULL() to fix this. Fixes: 028ddcac47 ("bcache: Remove unnecessary NULL point check in node allocations") Link: https://lore.kernel.org/all/3DF4A87A-2AC1-4893-AE5F-E921478419A9@suse.de/ Cc: stable@vger.kernel.org Cc: Zheng Wang <zyytlz.wz@163.com> Cc: Coly Li <colyli@suse.de> Signed-off-by: Markus Weippert <markus@gekmihesg.de> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-12-08 08:48:01 +01:00
..
alloc.c
bcache.h
bset.c
bset.h
btree.c	bcache: revert replacing IS_ERR_OR_NULL with IS_ERR	2023-12-08 08:48:01 +01:00
btree.h	bcache: fixup btree_cache_wait list damage	2023-07-23 13:47:32 +02:00
closure.c
closure.h
debug.c
debug.h
extents.c
extents.h
features.c
features.h
io.c
journal.c	bcache: avoid journal no-space deadlock by reserving 1 journal bucket	2022-06-09 10:23:29 +02:00
journal.h	bcache: avoid journal no-space deadlock by reserving 1 journal bucket	2022-06-09 10:23:29 +02:00
Kconfig
Makefile
movinggc.c
request.c	md: bcache: check the return value of kzalloc() in detached_dev_do_request()	2022-06-09 10:23:32 +02:00
request.h
stats.c
stats.h
super.c	bcache: Remove unnecessary NULL point check in node allocations	2023-07-23 13:47:32 +02:00
sysfs.c	bcache: prevent potential division by zero error	2023-12-03 07:31:25 +01:00
sysfs.h
trace.c
util.c
util.h
writeback.c	bcache: fixup lock c->root error	2023-12-03 07:31:25 +01:00
writeback.h	bcache: improve multithreaded bch_sectors_dirty_init()	2022-06-09 10:23:28 +02:00