Vladimir Oltean fb66df20a7 net/sched: taprio: extend minimum interval restriction to entire cycle too ... It is possible for syzbot to side-step the restriction imposed by the blamed commit in the Fixes: tag, because the taprio UAPI permits a cycle-time different from (and potentially shorter than) the sum of entry intervals. We need one more restriction, which is that the cycle time itself must be larger than N * ETH_ZLEN bit times, where N is the number of schedule entries. This restriction needs to apply regardless of whether the cycle time came from the user or was the implicit, auto-calculated value, so we move the existing "cycle == 0" check outside the "if "(!new->cycle_time)" branch. This way covers both conditions and scenarios. Add a selftest which illustrates the issue triggered by syzbot. Fixes: b5b73b26b3 ("taprio: Fix allowing too small intervals") Reported-by: syzbot+a7d2b1d5d1af83035567@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/0000000000007d66bc06196e7c66@google.com/ Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://lore.kernel.org/r/20240527153955.553333-2-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-05-28 19:46:41 -07:00
..
actions	selftests/tc-testing: require an up to date iproute2 for blockcast tests	2024-03-04 19:30:57 -08:00
filters	selftests: tc-testing: remove filters/tests.json	2023-11-30 23:22:18 -08:00
infra	selftests/tc-testing: update test definitions for local resources	2023-09-28 09:51:07 +02:00
qdiscs	net/sched: taprio: extend minimum interval restriction to entire cycle too	2024-05-28 19:46:41 -07:00