linux/tools/lib/perf/include/internal
Ian Rogers 1947b92464 libperf evlist: Avoid out-of-bounds access
Parallel testing appears to show a race between allocating and setting
evsel ids. As there is a bounds check on the xyarray it yields a segv
like:

```
AddressSanitizer:DEADLYSIGNAL

=================================================================

==484408==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000010

==484408==The signal is caused by a WRITE memory access.

==484408==Hint: address points to the zero page.

    #0 0x55cef5d4eff4 in perf_evlist__id_hash tools/lib/perf/evlist.c:256
    #1 0x55cef5d4f132 in perf_evlist__id_add tools/lib/perf/evlist.c:274
    #2 0x55cef5d4f545 in perf_evlist__id_add_fd tools/lib/perf/evlist.c:315
    #3 0x55cef5a1923f in store_evsel_ids util/evsel.c:3130
    #4 0x55cef5a19400 in evsel__store_ids util/evsel.c:3147
    #5 0x55cef5888204 in __run_perf_stat tools/perf/builtin-stat.c:832
    #6 0x55cef5888c06 in run_perf_stat tools/perf/builtin-stat.c:960
    #7 0x55cef58932db in cmd_stat tools/perf/builtin-stat.c:2878
...
```

Avoid this crash by early exiting the perf_evlist__id_add_fd and
perf_evlist__id_add is the access is out-of-bounds.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240229070757.796244-1-irogers@google.com
2024-02-29 13:57:02 -08:00
..
cpumap.h perf cpumap: Add reference count checking 2023-04-17 16:50:02 -03:00
evlist.h libperf evlist: Avoid out-of-bounds access 2024-02-29 13:57:02 -08:00
evsel.h perf evlist: Propagate user CPU maps intersecting core PMU maps 2023-05-27 09:38:39 -03:00
lib.h libperf: Add preadn() 2022-05-23 10:11:12 -03:00
mmap.h libperf: Lazily allocate/size mmap event copy 2023-11-30 19:25:19 -03:00
rc_check.h libperf rc_check: Add RC_CHK_EQUAL 2023-10-25 13:37:22 -07:00
tests.h libperf tests: Fix verbose printing 2021-08-24 15:05:35 -03:00
threadmap.h
xyarray.h libperf xyarray: Add bounds checks to xyarray__entry() 2021-04-20 08:11:33 -03:00