mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 04:18:39 +08:00
6e0391e48c
A root node is required to apply DT overlays. A root node is usually present after commit7b937cc243("of: Create of_root if no dtb provided by firmware"), except for on arm64 systems booted with ACPI tables. In that case, the root node is intentionally not populated because it would "allow DT devices to be instantiated atop an ACPI base system"[1]. Introduce an OF function that skips the kunit test if the root node isn't populated. Limit the test to when both CONFIG_ARM64 and CONFIG_ACPI are set, because otherwise the lack of a root node is a bug. Make the function private and take a kunit test parameter so that it can't be abused to test for the presence of the root node in non-test code. Use this function to skip tests that require the root node. Currently that's the DT tests and any tests that apply overlays. Reported-by: Guenter Roeck <linux@roeck-us.net> Closes: https://lore.kernel.org/r/6cd337fb-38f0-41cb-b942-5844b84433db@roeck-us.net Link: https://lore.kernel.org/r/Zd4dQpHO7em1ji67@FVFF77S0Q05N.cambridge.arm.com [1] Fixes:893ecc6d2d("of: Add KUnit test to confirm DTB is loaded") Signed-off-by: Stephen Boyd <sboyd@kernel.org> Tested-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Mark Rutland <mark.rutland@arm.com> Link: https://lore.kernel.org/r/20241009204133.1169931-1-sboyd@kernel.org Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
62 lines
1.3 KiB
C
62 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* KUnit tests for OF APIs
|
|
*/
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
|
|
#include <kunit/test.h>
|
|
|
|
#include "of_private.h"
|
|
|
|
/*
|
|
* Test that the root node "/" can be found by path.
|
|
*/
|
|
static void of_dtb_root_node_found_by_path(struct kunit *test)
|
|
{
|
|
struct device_node *np;
|
|
|
|
np = of_find_node_by_path("/");
|
|
KUNIT_EXPECT_NOT_ERR_OR_NULL(test, np);
|
|
of_node_put(np);
|
|
}
|
|
|
|
/*
|
|
* Test that the 'of_root' global variable is always populated when DT code is
|
|
* enabled. Remove this test once of_root is removed from global access.
|
|
*/
|
|
static void of_dtb_root_node_populates_of_root(struct kunit *test)
|
|
{
|
|
KUNIT_EXPECT_NOT_ERR_OR_NULL(test, of_root);
|
|
}
|
|
|
|
static struct kunit_case of_dtb_test_cases[] = {
|
|
KUNIT_CASE(of_dtb_root_node_found_by_path),
|
|
KUNIT_CASE(of_dtb_root_node_populates_of_root),
|
|
{}
|
|
};
|
|
|
|
static int of_dtb_test_init(struct kunit *test)
|
|
{
|
|
of_root_kunit_skip(test);
|
|
if (!IS_ENABLED(CONFIG_OF_EARLY_FLATTREE))
|
|
kunit_skip(test, "requires CONFIG_OF_EARLY_FLATTREE");
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Test suite to confirm a DTB is loaded.
|
|
*/
|
|
static struct kunit_suite of_dtb_suite = {
|
|
.name = "of_dtb",
|
|
.test_cases = of_dtb_test_cases,
|
|
.init = of_dtb_test_init,
|
|
};
|
|
|
|
kunit_test_suites(
|
|
&of_dtb_suite,
|
|
);
|
|
MODULE_DESCRIPTION("KUnit tests for OF APIs");
|
|
MODULE_LICENSE("GPL");
|