Luiz Augusto von Dentz 0013017242 Bluetooth: L2CAP: Fix deadlock ... commit f1a8f402f1 upstream. This fixes the following deadlock introduced by 39a92a55be ("bluetooth/l2cap: sync sock recv cb and release") ============================================ WARNING: possible recursive locking detected 6.10.0-rc3-g4029dba6b6f1 #6823 Not tainted -------------------------------------------- kworker/u5:0/35 is trying to acquire lock: ffff888002ec2510 (&chan->lock#2/1){+.+.}-{3:3}, at: l2cap_sock_recv_cb+0x44/0x1e0 but task is already holding lock: ffff888002ec2510 (&chan->lock#2/1){+.+.}-{3:3}, at: l2cap_get_chan_by_scid+0xaf/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&chan->lock#2/1); lock(&chan->lock#2/1); *** DEADLOCK *** May be due to missing lock nesting notation 3 locks held by kworker/u5:0/35: #0: ffff888002b8a940 ((wq_completion)hci0#2){+.+.}-{0:0}, at: process_one_work+0x750/0x930 #1: ffff888002c67dd0 ((work_completion)(&hdev->rx_work)){+.+.}-{0:0}, at: process_one_work+0x44e/0x930 #2: ffff888002ec2510 (&chan->lock#2/1){+.+.}-{3:3}, at: l2cap_get_chan_by_scid+0xaf/0xd0 To fix the original problem this introduces l2cap_chan_lock at l2cap_conless_channel to ensure that l2cap_sock_recv_cb is called with chan->lock held. Fixes: 89e856e124 ("bluetooth/l2cap: sync sock recv cb and release") Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-07-25 09:49:20 +02:00
..
bluetooth.h	Bluetooth: Consolidate code around sk_alloc into a helper function	2024-06-12 11:03:20 +02:00
hci_core.h	Bluetooth: L2CAP: Fix rejecting L2CAP_CONN_PARAM_UPDATE_REQ	2024-06-21 14:35:51 +02:00
hci_mon.h	Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name	2023-10-25 12:03:16 +02:00
hci_sock.h	Bluetooth: Fix HCIGETDEVINFO regression	2022-09-08 14:33:53 -07:00
hci_sync.h	Bluetooth: L2CAP: Fix deadlock	2024-07-25 09:49:20 +02:00
hci.h	Bluetooth: add quirk for broken address properties	2024-04-10 16:28:24 +02:00
iso.h	Bluetooth: ISO: Add broadcast support	2022-07-22 17:14:13 -07:00
l2cap.h	Bluetooth: compute LE flow credits based on recvbuf space	2024-06-12 11:03:20 +02:00
mgmt.h	Bluetooth: MGMT: Fix marking SCAN_RSP as not connectable	2023-07-19 16:22:02 +02:00
rfcomm.h	Bluetooth: Replace zero-length array with flexible-array member	2020-02-28 08:30:02 +01:00
sco.h	Bluetooth: Add support for BT_PKT_STATUS CMSG data for SCO connections	2020-06-12 15:08:49 +02:00