linux/drivers/watchdog
Stefan Wahren 3f30085bd9 watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling
[ Upstream commit f33f5b1fd1 ]

Users report about the unexpected behavior for setting timeouts above
15 sec on Raspberry Pi. According to watchdog-api.rst the ioctl
WDIOC_SETTIMEOUT shouldn't fail because of hardware limitations.
But looking at the code shows that max_timeout based on the
register value PM_WDOG_TIME_SET, which is the maximum.

Since 664a39236e ("watchdog: Introduce hardware maximum heartbeat
in watchdog core") the watchdog core is able to handle this problem.

This fix has been tested with watchdog-test from selftests.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217374
Fixes: 664a39236e ("watchdog: Introduce hardware maximum heartbeat in watchdog core")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231112173251.4827-1-wahrenst@gmx.net
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-25 14:33:36 -08:00
..
acquirewdt.c
advantechwdt.c watchdog: advantechwdt: mark expected switch fall-through 2017-12-28 20:45:28 +01:00
alim1535_wdt.c watchdog: alim1535_wdt: mark expected switch fall-through 2017-12-28 20:45:28 +01:00
alim7101_wdt.c treewide: Switch DEFINE_TIMER callbacks to struct timer_list * 2017-11-21 15:57:05 -08:00
ar7_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
asm9260_wdt.c watchdog: asm9260_wdt: fix error handling in asm9260_wdt_probe() 2018-03-03 17:04:16 +01:00
aspeed_wdt.c watchdog: aspeed: fix hardware timeout calculation 2021-07-20 16:16:13 +02:00
at91rm9200_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
at91sam9_wdt.c watchdog: at91sam9_wdt: use devm_request_irq to avoid missing free_irq() in error path 2023-03-11 16:31:58 +01:00
at91sam9_wdt.h watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
ath79_wdt.c
atlas7_wdt.c
bcm47xx_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
bcm63xx_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
bcm2835_wdt.c watchdog: bcm2835_wdt: Fix WDIOC_SETTIMEOUT handling 2024-01-25 14:33:36 -08:00
bcm7038_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
bcm_kona_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
booke_wdt.c
cadence_wdt.c watchdog: simplify getting .drvdata 2018-05-21 21:24:40 +02:00
coh901327_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
cpu5wdt.c treewide: setup_timer() -> timer_setup() 2017-11-21 15:57:07 -08:00
cpwd.c
da9052_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
da9055_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
da9062_wdt.c watchdog: da9062: No need to ping manually before setting timeout 2020-06-25 15:32:58 +02:00
da9063_wdt.c watchdog: da9063: remove duplicated timeout_to_sel calls 2018-06-07 12:41:43 +02:00
davinci_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
diag288_wdt.c watchdog: diag288_wdt: fix __diag288() inline assembly 2023-02-22 12:47:15 +01:00
digicolor_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
dw_wdt.c watchdog: dw: save/restore control and timeout across suspend/resume 2018-03-13 19:14:19 +01:00
ebc-c384_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
ep93xx_wdt.c
eurotechwdt.c watchdog: eurotechwdt: mark expected switch fall-through 2017-12-28 20:45:51 +01:00
f71808e_wdt.c watchdog: f71808e_wdt: fix inaccurate report in WDIOC_GETTIMEOUT 2021-11-26 11:36:15 +01:00
ftwdt010_wdt.c watchdog: ftwdt010: Make interrupt optional 2017-12-28 20:45:02 +01:00
gef_wdt.c
geodewdt.c
gpio_wdt.c watchdog: gpio: change order for setting default timeout 2018-03-03 17:04:15 +01:00
hpwdt.c watchdog/hpwdt: Only claim UNKNOWN NMI if from iLO 2024-01-25 14:33:36 -08:00
i6300esb.c watchdog: i6300esb: remove info message and version number 2017-12-28 20:45:18 +01:00
ib700wdt.c watchdog: ib700wdt: mark expected switch fall-through 2017-12-28 20:45:52 +01:00
ibmasr.c
ie6xx_wdt.c
imgpdc_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
imx2_wdt.c watchdog: imx2_wdt: fix min() calculation in imx2_wdt_set_timeout 2019-10-11 18:21:00 +02:00
indydog.c
intel_scu_watchdog.c
intel_scu_watchdog.h
intel-mid_wdt.c watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load 2023-09-23 10:48:13 +02:00
iop_wdt.c
it87_wdt.c
it8712f_wdt.c
iTCO_vendor_support.c
iTCO_vendor.h
iTCO_wdt.c watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running 2023-10-10 21:44:59 +02:00
ixp4xx_wdt.c
jz4740_wdt.c watchdog: JZ4740: Drop module remove function 2018-05-14 23:58:23 +01:00
Kconfig ar7: fix kernel builds for compiler test 2021-11-26 11:36:15 +01:00
kempld_wdt.c include/linux/compiler*.h: make compiler-*.h mutually exclusive 2018-08-22 17:31:34 -07:00
ks8695_wdt.c
lantiq_wdt.c
loongson1_wdt.c
lpc18xx_wdt.c watchdog: Fix possible use-after-free by calling del_timer_sync() 2021-07-20 16:16:11 +02:00
m54xx_wdt.c
machzwd.c treewide: Switch DEFINE_TIMER callbacks to struct timer_list * 2017-11-21 15:57:05 -08:00
Makefile watchdog: add driver for the MEN 16z069 IP-Core 2018-08-02 15:57:12 +02:00
max63xx_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
max77620_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
mei_wdt.c watchdog: mei_wdt: request stop on unregister 2021-03-04 09:39:55 +01:00
mena21_wdt.c watchdog: mena21_wdt: Drop unnecessary mutex lock 2018-05-21 21:25:23 +02:00
menf21bmc_wdt.c
menz69_wdt.c watchdog: menz069_wdt: fix watchdog initialisation 2023-06-09 10:23:57 +02:00
meson_gxbb_wdt.c watchdog: meson: Fix the wrong value of left time 2019-12-05 09:19:44 +01:00
meson_wdt.c watchdog: meson: allow setting timeout in devicetree 2018-03-03 17:04:14 +01:00
mixcomwd.c treewide: Switch DEFINE_TIMER callbacks to struct timer_list * 2017-11-21 15:57:05 -08:00
moxart_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
mpc8xxx_wdt.c watchdog: mpc8xxx: use the core worker function 2017-12-28 20:45:36 +01:00
mt7621_wdt.c watchdog: mt7621_wdt/rt2880_wdt: Fix compilation problem 2019-02-27 10:08:52 +01:00
mtk_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
mtx-1_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
mv64x60_wdt.c
ni903x_wdt.c
nic7018_wdt.c
npcm_wdt.c watchdog: Add Nuvoton NPCM watchdog driver 2018-03-24 10:19:39 +01:00
nuc900_wdt.c treewide: setup_timer() -> timer_setup() 2017-11-21 15:57:07 -08:00
nv_tco.c
nv_tco.h
octeon-wdt-main.c
octeon-wdt-nmi.S
of_xilinx_wdt.c watchdog: simplify getting .drvdata 2018-05-21 21:24:40 +02:00
omap_wdt.c watchdog: Fix OMAP watchdog early handling 2021-11-26 11:35:59 +01:00
omap_wdt.h
orion_wdt.c watchdog: orion_wdt: Mark watchdog as active when running at probe 2018-08-02 15:57:09 +02:00
pc87413_wdt.c
pcwd_pci.c watchdog: pcwd_pci: mark expected switch fall-through 2017-12-28 20:45:29 +01:00
pcwd_usb.c watchdog: pcwd_usb: Fix attempting to access uninitialized memory 2023-03-11 16:31:58 +01:00
pcwd.c treewide: setup_timer() -> timer_setup() 2017-11-21 15:57:07 -08:00
pic32-dmt.c
pic32-wdt.c
pika_wdt.c treewide: setup_timer() -> timer_setup() 2017-11-21 15:57:07 -08:00
pnx833x_wdt.c
pnx4008_wdt.c watchdog: pnx4008: make use of timeout-secs provided in devicetree 2018-03-03 17:04:13 +01:00
pretimeout_noop.c
pretimeout_panic.c
qcom-wdt.c watchdog: qcom: Avoid context switch in restart handler 2020-12-30 11:26:05 +01:00
rave-sp-wdt.c watchdog: Add RAVE SP watchdog driver 2018-01-08 10:08:36 +00:00
rc32434_wdt.c
rdc321x_wdt.c drivers: watchdog: rdc321x_wdt: Fix race condition bugs 2020-11-05 11:08:44 +01:00
renesas_wdt.c watchdog: renesas_wdt: stop when unregistering 2019-11-24 08:19:41 +01:00
retu_wdt.c
riowd.c
rn5t618_wdt.c watchdog: rn5t618_wdt: fix module aliases 2020-02-01 09:37:08 +00:00
rt2880_wdt.c watchdog: mt7621_wdt/rt2880_wdt: Fix compilation problem 2019-02-27 10:08:52 +01:00
rtd119x_wdt.c watchdog: rtd119x_wdt: Fix remove function 2020-01-27 14:50:45 +01:00
rza_wdt.c
s3c2410_wdt.c
sa1100_wdt.c
sama5d4_wdt.c watchdog: sama5d4: fix WDD value to be always set to max 2019-12-05 09:21:32 +01:00
sb_wdog.c
sbc60xxwdt.c watchdog: Fix possible use-after-free in wdt_startup() 2021-07-20 16:16:11 +02:00
sbc7240_wdt.c
sbc8360.c
sbc_epx_c3.c
sbc_fitpc2_wdt.c
sbsa_gwdt.c watchdog: sbsa_wdog: Make sure the timeout programming is within the limits 2023-04-20 12:04:41 +02:00
sc520_wdt.c watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff() 2021-07-20 16:16:11 +02:00
sc1200wdt.c
sch311x_wdt.c watchdog: sch311x_wdt: Mark expected switch fall-through 2018-04-16 10:22:39 +02:00
scx200_wdt.c
shwdt.c treewide: setup_timer() -> timer_setup() 2017-11-21 15:57:07 -08:00
sirfsoc_wdt.c watchdog: sirfsoc: allow setting timeout in devicetree 2018-03-03 17:04:13 +01:00
smsc37b787_wdt.c
softdog.c
sp805_wdt.c watchdog: sp805: fix restart handler 2020-04-23 10:30:12 +02:00
sp5100_tco.c watchdog: sp5100_tco: Add support for recent FCH versions 2018-01-21 12:56:37 +01:00
sp5100_tco.h watchdog: sp5100: Fix definition of EFCH_PM_DECODEEN3 2020-10-30 10:38:22 +01:00
sprd_wdt.c watchdog: sprd: check busy bit before new loading rather than after that 2020-12-30 11:26:03 +01:00
st_lpc_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
stm32_iwdg.c watchdog: stm32: add pclk feature for stm32mp1 2018-08-02 15:57:09 +02:00
stmp3xxx_rtc_wdt.c watchdog: stmp3xxx: Switch to SPDX identifier 2018-08-02 15:57:11 +02:00
sun4v_wdt.c
sunxi_wdt.c watchdog: sunxi: allow setting timeout in devicetree 2018-03-03 17:04:13 +01:00
tangox_wdt.c headers: separate linux/mod_devicetable.h from linux/platform_device.h 2018-07-07 17:52:26 +02:00
tegra_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
ts72xx_wdt.c
ts4800_wdt.c
twl4030_wdt.c
txx9wdt.c
uniphier_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
ux500_wdt.c
via_wdt.c treewide: Switch DEFINE_TIMER callbacks to struct timer_list * 2017-11-21 15:57:05 -08:00
w83627hf_wdt.c watchdog: w83627hf_wdt: Support NCT6796D, NCT6797D, NCT6798D 2019-11-24 08:19:43 +01:00
w83877f_wdt.c watchdog: Fix possible use-after-free by calling del_timer_sync() 2021-07-20 16:16:11 +02:00
w83977f_wdt.c watchdog: w83977f_wdt: Mark expected switch fall-through 2018-04-16 10:22:39 +02:00
wafer5823wdt.c watchdog: wafer5823wdt: Mark expected switch fall-through 2018-04-16 10:22:39 +02:00
watchdog_core.c watchdog: Fix potential dereferencing of null pointer 2020-12-30 11:26:04 +01:00
watchdog_core.h
watchdog_dev.c watchdog: set cdev owner before adding 2024-01-25 14:33:36 -08:00
watchdog_pretimeout.c
watchdog_pretimeout.h
wd501p.h
wdat_wdt.c ACPI: watchdog: Fix gas->access_width usage 2020-03-05 16:42:17 +01:00
wdrtas.c
wdt285.c
wdt977.c
wdt_pci.c watchdog: wdt_pci: mark expected switch fall-through 2017-12-28 20:45:30 +01:00
wdt.c
wm831x_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
wm8350_wdt.c watchdog: add SPDX identifiers for watchdog subsystem 2018-03-24 10:19:40 +01:00
xen_wdt.c watchdog: xen_wdt: remove info message and version number 2017-12-28 20:45:44 +01:00
ziirave_wdt.c
zx2967_wdt.c