Tony Lindgren 486218c11e phy: ti: phy-omap-usb2: Fix NULL pointer dereference for SRP ... [ Upstream commit 7104ba0f19 ] If the external phy working together with phy-omap-usb2 does not implement send_srp(), we may still attempt to call it. This can happen on an idle Ethernet gadget triggering a wakeup for example: configfs-gadget.g1 gadget.0: ECM Suspend configfs-gadget.g1 gadget.0: Port suspended. Triggering wakeup ... Unable to handle kernel NULL pointer dereference at virtual address 00000000 when execute ... PC is at 0x0 LR is at musb_gadget_wakeup+0x1d4/0x254 [musb_hdrc] ... musb_gadget_wakeup [musb_hdrc] from usb_gadget_wakeup+0x1c/0x3c [udc_core] usb_gadget_wakeup [udc_core] from eth_start_xmit+0x3b0/0x3d4 [u_ether] eth_start_xmit [u_ether] from dev_hard_start_xmit+0x94/0x24c dev_hard_start_xmit from sch_direct_xmit+0x104/0x2e4 sch_direct_xmit from __dev_queue_xmit+0x334/0xd88 __dev_queue_xmit from arp_solicit+0xf0/0x268 arp_solicit from neigh_probe+0x54/0x7c neigh_probe from __neigh_event_send+0x22c/0x47c __neigh_event_send from neigh_resolve_output+0x14c/0x1c0 neigh_resolve_output from ip_finish_output2+0x1c8/0x628 ip_finish_output2 from ip_send_skb+0x40/0xd8 ip_send_skb from udp_send_skb+0x124/0x340 udp_send_skb from udp_sendmsg+0x780/0x984 udp_sendmsg from __sys_sendto+0xd8/0x158 __sys_sendto from ret_fast_syscall+0x0/0x58 Let's fix the issue by checking for send_srp() and set_vbus() before calling them. For USB peripheral only cases these both could be NULL. Fixes: 657b306a7b ("usb: phy: add a new driver for omap usb2 phy") Signed-off-by: Tony Lindgren <tony@atomide.com> Link: https://lore.kernel.org/r/20240128120556.8848-1-tony@atomide.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-02-23 08:12:53 +01:00
..
allwinner	phy: sun4i-usb: fix dereference of pointer phy0 before it is null checked	2020-07-22 09:32:05 +02:00
amlogic
broadcom
hisilicon	phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe()	2023-08-11 11:45:30 +02:00
lantiq
marvell	phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally	2021-05-22 10:59:29 +02:00
mediatek
motorola	phy: mapphone-mdm6600: Fix runtime PM for remove	2023-10-25 11:17:02 +02:00
qualcomm	phy: qualcomm: call clk_disable_unprepare in the error handling	2022-10-26 13:19:33 +02:00
ralink
renesas
rockchip	phy: rockchip-typec: Fix unsigned comparison with less than zero	2023-03-11 16:32:01 +01:00
samsung	phy: samsung: exynos5250-sata: fix missing device put in probe error paths	2022-05-12 12:20:20 +02:00
st	phy: st: miphy28lp: use _poll_timeout functions for waits	2023-05-30 12:42:10 +01:00
tegra	phy: tegra: xusb: Add missing tegra_xusb_port_unregister for usb2_port and ulpi_port	2023-05-17 11:13:20 +02:00
ti	phy: ti: phy-omap-usb2: Fix NULL pointer dereference for SRP	2024-02-23 08:12:53 +01:00
Kconfig
Makefile
phy-core.c
phy-lpc18xx-usb-otg.c
phy-pistachio-usb.c
phy-xgene.c