Brian Geffon d437f97a25 PM: hibernate: Clean up sync_read handling in snapshot_write_next() ... commit d08970df19 upstream. In snapshot_write_next(), sync_read is set and unset in three different spots unnecessiarly. As a result there is a subtle bug where the first page after the meta data has been loaded unconditionally sets sync_read to 0. If this first PFN was actually a highmem page, then the returned buffer will be the global "buffer," and the page needs to be loaded synchronously. That is, I'm not sure we can always assume the following to be safe: handle->buffer = get_buffer(&orig_bm, &ca); handle->sync_read = 0; Because get_buffer() can call get_highmem_page_buffer() which can return 'buffer'. The easiest way to address this is just set sync_read before snapshot_write_next() returns if handle->buffer == buffer. Signed-off-by: Brian Geffon <bgeffon@google.com> Fixes: 8357376d3d ("[PATCH] swsusp: Improve handling of highmem") Cc: All applicable <stable@vger.kernel.org> [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-11-28 16:45:45 +00:00
..
autosleep.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
console.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hibernate.c	PM: hibernate: Allow hybrid sleep to work with s2idle	2022-11-03 23:50:55 +09:00
Kconfig	PM / sleep: wakeup: Fix build error caused by missing SRCU support	2018-09-09 19:55:58 +02:00
main.c	ACPI / PM: Check low power idle constraints for debug only	2017-08-18 01:54:22 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
power.h	x86/power: Fix swsusp_arch_resume prototype	2018-04-26 11:02:16 +02:00
poweroff.c	power/sysrq: fix inconstistent help message of sysrq key	2013-04-30 17:04:10 -07:00
process.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
qos.c	power, workqueue: remove keventd_up() usage	2016-09-17 13:18:21 -04:00
snapshot.c	PM: hibernate: Clean up sync_read handling in snapshot_write_next()	2023-11-28 16:45:45 +00:00
suspend_test.c	PM: suspend: fix return value of __setup handler	2022-04-20 09:08:13 +02:00
suspend.c	PM / wakeup: Make s2idle_lock a RAW_SPINLOCK	2018-08-03 07:50:29 +02:00
swap.c	PM: hibernate: fix sparse warnings	2021-11-26 11:40:31 +01:00
user.c	PM: hibernate: defer device probing when resuming from hibernation	2022-08-25 11:11:14 +02:00
wakelock.c	PM: wakeup: simplify the output logic of pm_show_wakelocks()	2022-02-08 18:16:24 +01:00