korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 12:28:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

drivers/perf: convert sysfs sprintf family to sysfs_emit

Browse Source 
sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for sysfs content and it's possible to overrun the buffer length.

Use sysfs_emit() function to ensures that no overrun is done.

Signed-off-by: Qi Liu <liuqi115@huawei.com>
Link: https://lore.kernel.org/r/1616148273-16374-4-git-send-email-liuqi115@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
This commit is contained in:
Qi Liu 2021-03-19 18:04:33 +08:00 committed by Will Deacon
parent 9ec9f9cf86
commit fb62d67586
8 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/perf/arm_dmc620_pmu.c
View File

@ -113,7 +113,7 @@ dmc620_pmu_event_show(struct device *dev,
eattr = container_of(attr, typeof(*eattr), attr); eattr = container_of(attr, typeof(*eattr), attr);
return sprintf(page, "event=0x%x,clkdiv2=0x%x\n", eattr->eventid, eattr->clkdiv2); return sysfs_emit(page, "event=0x%x,clkdiv2=0x%x\n", eattr->eventid, eattr->clkdiv2);
} }
#define DMC620_PMU_EVENT_ATTR(_name, _eventid, _clkdiv2) \ #define DMC620_PMU_EVENT_ATTR(_name, _eventid, _clkdiv2) \

2
drivers/perf/arm_smmuv3_pmu.c
View File

@ -506,7 +506,7 @@ static ssize_t smmu_pmu_event_show(struct device *dev,
pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr); pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);
return sprintf(page, "event=0x%02llx\n", pmu_attr->id); return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);
} }
#define SMMU_EVENT_ATTR(name, config) \ #define SMMU_EVENT_ATTR(name, config) \

4
drivers/perf/fsl_imx8_ddr_perf.c
View File

@ -110,7 +110,7 @@ static ssize_t ddr_perf_identifier_show(struct device *dev,
{ {
struct ddr_pmu *pmu = dev_get_drvdata(dev); struct ddr_pmu *pmu = dev_get_drvdata(dev);
return sprintf(page, "%s\n", pmu->devtype_data->identifier); return sysfs_emit(page, "%s\n", pmu->devtype_data->identifier);
} }
static umode_t ddr_perf_identifier_attr_visible(struct kobject *kobj, static umode_t ddr_perf_identifier_attr_visible(struct kobject *kobj,
@ -219,7 +219,7 @@ ddr_pmu_event_show(struct device *dev, struct device_attribute *attr,
struct perf_pmu_events_attr *pmu_attr; struct perf_pmu_events_attr *pmu_attr;
pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr); pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);
return sprintf(page, "event=0x%02llx\n", pmu_attr->id); return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);
} }
#define IMX8_DDR_PMU_EVENT_ATTR(_name, _id) \ #define IMX8_DDR_PMU_EVENT_ATTR(_name, _id) \

6
drivers/perf/hisilicon/hisi_uncore_pmu.c
View File

@ -33,7 +33,7 @@ ssize_t hisi_format_sysfs_show(struct device *dev,
eattr = container_of(attr, struct dev_ext_attribute, attr); eattr = container_of(attr, struct dev_ext_attribute, attr);
return sprintf(buf, "%s\n", (char *)eattr->var); return sysfs_emit(buf, "%s\n", (char *)eattr->var);
} }
EXPORT_SYMBOL_GPL(hisi_format_sysfs_show); EXPORT_SYMBOL_GPL(hisi_format_sysfs_show);
@ -47,7 +47,7 @@ ssize_t hisi_event_sysfs_show(struct device *dev,
eattr = container_of(attr, struct dev_ext_attribute, attr); eattr = container_of(attr, struct dev_ext_attribute, attr);
return sprintf(page, "config=0x%lx\n", (unsigned long)eattr->var); return sysfs_emit(page, "config=0x%lx\n", (unsigned long)eattr->var);
} }
EXPORT_SYMBOL_GPL(hisi_event_sysfs_show); EXPORT_SYMBOL_GPL(hisi_event_sysfs_show);
@ -59,7 +59,7 @@ ssize_t hisi_cpumask_sysfs_show(struct device *dev,
{ {
struct hisi_pmu *hisi_pmu = to_hisi_pmu(dev_get_drvdata(dev)); struct hisi_pmu *hisi_pmu = to_hisi_pmu(dev_get_drvdata(dev));
return sprintf(buf, "%d\n", hisi_pmu->on_cpu); return sysfs_emit(buf, "%d\n", hisi_pmu->on_cpu);
} }
EXPORT_SYMBOL_GPL(hisi_cpumask_sysfs_show); EXPORT_SYMBOL_GPL(hisi_cpumask_sysfs_show);

2
drivers/perf/qcom_l2_pmu.c
View File

@ -676,7 +676,7 @@ static ssize_t l2cache_pmu_event_show(struct device *dev,
struct perf_pmu_events_attr *pmu_attr; struct perf_pmu_events_attr *pmu_attr;
pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr); pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);
return sprintf(page, "event=0x%02llx\n", pmu_attr->id); return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);
} }
#define L2CACHE_EVENT_ATTR(_name, _id) \ #define L2CACHE_EVENT_ATTR(_name, _id) \

4
drivers/perf/qcom_l3_pmu.c
View File

@ -615,7 +615,7 @@ static ssize_t l3cache_pmu_format_show(struct device *dev,
struct dev_ext_attribute *eattr; struct dev_ext_attribute *eattr;
eattr = container_of(attr, struct dev_ext_attribute, attr); eattr = container_of(attr, struct dev_ext_attribute, attr);
return sprintf(buf, "%s\n", (char *) eattr->var); return sysfs_emit(buf, "%s\n", (char *) eattr->var);
} }
#define L3CACHE_PMU_FORMAT_ATTR(_name, _config) \ #define L3CACHE_PMU_FORMAT_ATTR(_name, _config) \
@ -643,7 +643,7 @@ static ssize_t l3cache_pmu_event_show(struct device *dev,
struct perf_pmu_events_attr *pmu_attr; struct perf_pmu_events_attr *pmu_attr;
pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr); pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);
return sprintf(page, "event=0x%02llx\n", pmu_attr->id); return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);
} }
#define L3CACHE_EVENT_ATTR(_name, _id) \ #define L3CACHE_EVENT_ATTR(_name, _id) \

4
drivers/perf/thunderx2_pmu.c
View File

@ -128,7 +128,7 @@ __tx2_pmu_##_var##_show(struct device *dev, \
char *page) \ char *page) \
{ \ { \
BUILD_BUG_ON(sizeof(_format) >= PAGE_SIZE); \ BUILD_BUG_ON(sizeof(_format) >= PAGE_SIZE); \
return sprintf(page, _format "\n"); \ return sysfs_emit(page, _format "\n"); \
} \ } \
\ \
static struct device_attribute format_attr_##_var = \ static struct device_attribute format_attr_##_var = \
@ -176,7 +176,7 @@ static ssize_t tx2_pmu_event_show(struct device *dev,
struct dev_ext_attribute *eattr; struct dev_ext_attribute *eattr;
eattr = container_of(attr, struct dev_ext_attribute, attr); eattr = container_of(attr, struct dev_ext_attribute, attr);
return sprintf(buf, "event=0x%lx\n", (unsigned long) eattr->var); return sysfs_emit(buf, "event=0x%lx\n", (unsigned long) eattr->var);
} }
#define TX2_EVENT_ATTR(name, config) \ #define TX2_EVENT_ATTR(name, config) \

4
drivers/perf/xgene_pmu.c
View File

@ -170,7 +170,7 @@ static ssize_t xgene_pmu_format_show(struct device *dev,
struct dev_ext_attribute *eattr; struct dev_ext_attribute *eattr;
eattr = container_of(attr, struct dev_ext_attribute, attr); eattr = container_of(attr, struct dev_ext_attribute, attr);
return sprintf(buf, "%s\n", (char *) eattr->var); return sysfs_emit(buf, "%s\n", (char *) eattr->var);
} }
#define XGENE_PMU_FORMAT_ATTR(_name, _config) \ #define XGENE_PMU_FORMAT_ATTR(_name, _config) \
@ -281,7 +281,7 @@ static ssize_t xgene_pmu_event_show(struct device *dev,
struct dev_ext_attribute *eattr; struct dev_ext_attribute *eattr;
eattr = container_of(attr, struct dev_ext_attribute, attr); eattr = container_of(attr, struct dev_ext_attribute, attr);
return sprintf(buf, "config=0x%lx\n", (unsigned long) eattr->var); return sysfs_emit(buf, "config=0x%lx\n", (unsigned long) eattr->var);
} }
#define XGENE_PMU_EVENT_ATTR(_name, _config) \ #define XGENE_PMU_EVENT_ATTR(_name, _config) \