korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-16 16:54:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

USB: gadget: ci13xx_udc: fix potential crash in irq handler

Browse Source 
As pointed out by Dan Carpenter, we should not be trying to call
dev_err() on a structure that was previously determined to be NULL,
that's just foolish and asking for trouble.

So just delete the message, it's not going to do anyone any good to have
it anyway.

This problem was caused by 0f089094cd: "usb: gadget: ci13xxx: replace
home-brewed logging with dev_{err,warn,info}"

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2012-05-10 11:37:18 -07:00
parent 126625e1bf
commit f639554b8a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/ci13xxx_udc.c
View File

@ -2719,10 +2719,8 @@ static irqreturn_t udc_irq(int irq, void *data)
trace(udc ? udc->dev : NULL, "");
if (udc == NULL) {
dev_err(udc->dev, "ENODEV");
if (udc == NULL)
return IRQ_HANDLED;
}
spin_lock(&udc->lock);