mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-28 22:54:05 +08:00
hwmon: (npcm750-pwm-fan) Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Jean Delvare <jdelvare@suse.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-hwmon@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> [groeck: Dropped jz4740-hwmon.c (driver is being removed)] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
parent
6e4d91aa07
commit
f2ff7ceaa4
@ -967,10 +967,8 @@ static int npcm7xx_pwm_fan_probe(struct platform_device *pdev)
|
||||
spin_lock_init(&data->fan_lock[i]);
|
||||
|
||||
data->fan_irq[i] = platform_get_irq(pdev, i);
|
||||
if (data->fan_irq[i] < 0) {
|
||||
dev_err(dev, "get IRQ fan%d failed\n", i);
|
||||
if (data->fan_irq[i] < 0)
|
||||
return data->fan_irq[i];
|
||||
}
|
||||
|
||||
sprintf(name, "NPCM7XX-FAN-MD%d", i);
|
||||
ret = devm_request_irq(dev, data->fan_irq[i], npcm7xx_fan_isr,
|
||||
|
Loading…
Reference in New Issue
Block a user