HID: potential dereference of null pointer

commit 13251ce1dd upstream.

The return value of devm_kzalloc() needs to be checked.
To avoid hdev->dev->driver_data to be null in case of the failure of
alloc.

Fixes: 14c9c014ba ("HID: add vivaldi HID driver")
Cc: stable@vger.kernel.org
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20211215083605.117638-1-jiasheng@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jiasheng Jiang 2021-12-15 16:36:05 +08:00 committed by Greg Kroah-Hartman
parent 3110bc5862
commit ef2dce4325

View File

@ -57,6 +57,9 @@ static int vivaldi_probe(struct hid_device *hdev,
int ret; int ret;
drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL); drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
if (!drvdata)
return -ENOMEM;
hid_set_drvdata(hdev, drvdata); hid_set_drvdata(hdev, drvdata);
ret = hid_parse(hdev); ret = hid_parse(hdev);