mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-26 13:44:15 +08:00
net: sched: tapr: prevent cycle_time == 0 in parse_taprio_schedule
There is a reproducible sequence from the userland that will trigger a WARN_ON() condition in taprio_get_start_time, which causes kernel to panic if configured as "panic_on_warn". Catch this condition in parse_taprio_schedule to prevent this condition. Reported as bug on syzkaller: https://syzkaller.appspot.com/bug?extid=d50710fd0873a9c6b40c Reported-by: syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com Signed-off-by: Du Cheng <ducheng2@gmail.com> Acked-by: Cong Wang <cong.wang@bytedance.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
e16edc99d6
commit
ed8157f1eb
@ -901,6 +901,12 @@ static int parse_taprio_schedule(struct taprio_sched *q, struct nlattr **tb,
|
|||||||
|
|
||||||
list_for_each_entry(entry, &new->entries, list)
|
list_for_each_entry(entry, &new->entries, list)
|
||||||
cycle = ktime_add_ns(cycle, entry->interval);
|
cycle = ktime_add_ns(cycle, entry->interval);
|
||||||
|
|
||||||
|
if (!cycle) {
|
||||||
|
NL_SET_ERR_MSG(extack, "'cycle_time' can never be 0");
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
new->cycle_time = cycle;
|
new->cycle_time = cycle;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user