korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-20 02:34:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

powerpc/fsl-booke: Fix problem with _tlbil_va being interrupted

Browse Source 
An example calling sequence which we did see:

copy_user_highpage -> kmap_atomic -> flush_tlb_page -> _tlbil_va

We got interrupted after setting up the MAS registers before the
tlbwe and the interrupt handler that caused the interrupt also did
a kmap_atomic (ide code) and thus on returning from the interrupt
the MAS registers no longer contained the proper values.

Since we dont save/restore MAS registers for normal interrupts we
need to disable interrupts in _tlbil_va to ensure atomicity.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
This commit is contained in:
Kumar Gala 2008-12-13 17:01:37 -06:00
parent ab44f4627e
commit e5e774d883
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/powerpc/kernel/misc_32.S
View File

@ -479,6 +479,8 @@ _GLOBAL(_tlbil_pid)
* (no broadcast) * (no broadcast)
*/ */
_GLOBAL(_tlbil_va) _GLOBAL(_tlbil_va)
mfmsr r10
wrteei 0
slwi r4,r4,16 slwi r4,r4,16
mtspr SPRN_MAS6,r4 /* assume AS=0 for now */ mtspr SPRN_MAS6,r4 /* assume AS=0 for now */
tlbsx 0,r3 tlbsx 0,r3
@ -490,6 +492,7 @@ _GLOBAL(_tlbil_va)
tlbwe tlbwe
msync msync
isync isync
wrtee r10
blr blr
#endif /* CONFIG_FSL_BOOKE */ #endif /* CONFIG_FSL_BOOKE */