mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-15 08:14:15 +08:00
batman-adv: Remove unnecessary INIT_HLIST_NODE() calls
There's no need to for an explicit hlist_node initialization if it is added to a list right away, like it's the case with the hlist_add_head()s here. Signed-off-by: Linus Lüssing <linus.luessing@web.de> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
This commit is contained in:
parent
d4ff40f683
commit
e54c77f08e
@ -464,8 +464,6 @@ static void batadv_iv_ogm_aggregate_new(const unsigned char *packet_buff,
|
|||||||
}
|
}
|
||||||
skb_reserve(forw_packet_aggr->skb, ETH_HLEN);
|
skb_reserve(forw_packet_aggr->skb, ETH_HLEN);
|
||||||
|
|
||||||
INIT_HLIST_NODE(&forw_packet_aggr->list);
|
|
||||||
|
|
||||||
skb_buff = skb_put(forw_packet_aggr->skb, packet_len);
|
skb_buff = skb_put(forw_packet_aggr->skb, packet_len);
|
||||||
forw_packet_aggr->packet_len = packet_len;
|
forw_packet_aggr->packet_len = packet_len;
|
||||||
memcpy(skb_buff, packet_buff, packet_len);
|
memcpy(skb_buff, packet_buff, packet_len);
|
||||||
|
@ -152,8 +152,6 @@ _batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,
|
|||||||
struct batadv_forw_packet *forw_packet,
|
struct batadv_forw_packet *forw_packet,
|
||||||
unsigned long send_time)
|
unsigned long send_time)
|
||||||
{
|
{
|
||||||
INIT_HLIST_NODE(&forw_packet->list);
|
|
||||||
|
|
||||||
/* add new packet to packet list */
|
/* add new packet to packet list */
|
||||||
spin_lock_bh(&bat_priv->forw_bcast_list_lock);
|
spin_lock_bh(&bat_priv->forw_bcast_list_lock);
|
||||||
hlist_add_head(&forw_packet->list, &bat_priv->forw_bcast_list);
|
hlist_add_head(&forw_packet->list, &bat_priv->forw_bcast_list);
|
||||||
|
Loading…
Reference in New Issue
Block a user