net/ipv4: Bail early if user only wants prefix entries

Unlike IPv6, IPv4 does not have routes marked with RTF_PREFIX_RT. If the
flag is set in the dump request, just return.

In the process of this change, move the CLONE check to use the new
filter flags.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David Ahern 2018-10-15 18:56:51 -07:00 committed by David S. Miller
parent 08e814c9e8
commit e4e92fb160

View File

@ -886,10 +886,14 @@ static int inet_dump_fib(struct sk_buff *skb, struct netlink_callback *cb)
err = ip_valid_fib_dump_req(net, nlh, &filter, cb); err = ip_valid_fib_dump_req(net, nlh, &filter, cb);
if (err < 0) if (err < 0)
return err; return err;
} else if (nlmsg_len(nlh) >= sizeof(struct rtmsg)) {
struct rtmsg *rtm = nlmsg_data(nlh);
filter.flags = rtm->rtm_flags & (RTM_F_PREFIX | RTM_F_CLONED);
} }
if (nlmsg_len(nlh) >= sizeof(struct rtmsg) && /* fib entries are never clones and ipv4 does not use prefix flag */
((struct rtmsg *)nlmsg_data(nlh))->rtm_flags & RTM_F_CLONED) if (filter.flags & (RTM_F_PREFIX | RTM_F_CLONED))
return skb->len; return skb->len;
if (filter.table_id) { if (filter.table_id) {