korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-16 15:34:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf expr: Fix "has_event" function for metric style events

Browse Source 
[ Upstream commit 6dd76680b9 ]

Events in metrics cannot use '/' as a separator, it would be
recognized as a divide, so they use '@'. The '@' is recognized in the
metricgroups code and changed to '/', do the same in the has_event
function so that the parsing is only tried without the @s.

Fixes: 4a4a9bf907 ("perf expr: Add has_event function")
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: James Clark <james.clark@arm.com>
Cc: Kaige Ye <ye@kaige.org>
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240209204947.3873294-3-irogers@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ian Rogers 2024-02-09 12:49:45 -08:00 committed by Sasha Levin
parent 435e7f6474
commit e40ef597e5
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/perf/util/expr.c
View File

@ -500,7 +500,25 @@ double expr__has_event(const struct expr_parse_ctx *ctx, bool compute_ids, const
tmp = evlist__new();
if (!tmp)
return NAN;
ret = parse_event(tmp, id) ? 0 : 1;
if (strchr(id, '@')) {
char *tmp_id, *p;
tmp_id = strdup(id);
if (!tmp_id) {
ret = NAN;
goto out;
}
p = strchr(tmp_id, '@');
*p = '/';
p = strrchr(tmp_id, '@');
*p = '/';
ret = parse_event(tmp, tmp_id) ? 0 : 1;
free(tmp_id);
} else {
ret = parse_event(tmp, id) ? 0 : 1;
}
out:
evlist__delete(tmp);
return ret;
}