korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-29 14:05:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "x86/mce/AMD: Collect error info even if valid bits are not set"

Browse Source 
This reverts commit 4b1e84276a.

Software uses the valid bits to decide if the values can be used for
further processing or other actions. So setting the valid bits will have
software act on values that it shouldn't be acting on.

The recommendation to save all the register values does not mean that
the values are always valid.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: tony.luck@intel.com
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: bp@suse.de
Cc: linux-edac@vger.kernel.org
Link: https://lkml.kernel.org/r/20180326191526.64314-1-Yazen.Ghannam@amd.com
This commit is contained in:
Yazen Ghannam 2018-03-26 14:15:25 -05:00 committed by Thomas Gleixner
parent 24193c5de4
commit e2efacb6a5
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
arch/x86/kernel/cpu/mcheck/mce.c
View File

@ -446,20 +446,6 @@ static inline void mce_gather_info(struct mce *m, struct pt_regs *regs)
if (mca_cfg.rip_msr)
m->ip = mce_rdmsrl(mca_cfg.rip_msr);
}
/*
* Error handlers should save the values in MCA_ADDR, MCA_MISC0, and
* MCA_SYND even if MCA_STATUS[AddrV], MCA_STATUS[MiscV], and
* MCA_STATUS[SyndV] are zero.
*/
if (m->cpuvendor == X86_VENDOR_AMD) {
u64 status = MCI_STATUS_ADDRV | MCI_STATUS_MISCV;
if (mce_flags.smca)
status |= MCI_STATUS_SYNDV;
m->status |= status;
}
}
int mce_available(struct cpuinfo_x86 *c)