korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-27 22:24:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

mm: memory-failure: fix unexpected return value in soft_offline_page()

Browse Source 
When page_handle_poison() fails to handle the hugepage or free page in
retry path, soft_offline_page() will return 0 while -EBUSY is expected in
this case.

Consequently the user will think soft_offline_page succeeds while it in
fact failed.  So the user will not try again later in this case.

Link: https://lkml.kernel.org/r/20230627112808.1275241-1-linmiaohe@huawei.com
Fixes: b94e02822d ("mm,hwpoison: try to narrow window race for free pages")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Miaohe Lin 2023-06-27 19:28:08 +08:00 committed by Andrew Morton
parent d59070d107
commit e2c1ab070f
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mm/memory-failure.c
View File

@ -2741,11 +2741,14 @@ retry:
if (ret > 0) { if (ret > 0) {
ret = soft_offline_in_use_page(page); ret = soft_offline_in_use_page(page);
} else if (ret == 0) { } else if (ret == 0) {
if (!page_handle_poison(page, true, false) && try_again) { if (!page_handle_poison(page, true, false)) {
if (try_again) {
try_again = false; try_again = false;
flags &= ~MF_COUNT_INCREASED; flags &= ~MF_COUNT_INCREASED;
goto retry; goto retry;
} }
ret = -EBUSY;
}
} }
mutex_unlock(&mf_mutex); mutex_unlock(&mf_mutex);