mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-24 04:34:08 +08:00
spi: bcmbca-hsspi: Use devm_spi_alloc_host()
Use devm_spi_alloc_host() so that there's no need to call spi_controller_put() in the error path. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Reviewed-by: William Zhang <william.zhang@broadcom.com> Link: https://patch.msgid.link/20240826124903.3429235-3-ruanjinjie@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
4439a2e92c
commit
deb269e039
@ -480,7 +480,7 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev)
|
||||
}
|
||||
}
|
||||
|
||||
host = spi_alloc_host(&pdev->dev, sizeof(*bs));
|
||||
host = devm_spi_alloc_host(&pdev->dev, sizeof(*bs));
|
||||
if (!host) {
|
||||
ret = -ENOMEM;
|
||||
goto out_disable_pll_clk;
|
||||
@ -536,17 +536,17 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev)
|
||||
ret = devm_request_irq(dev, irq, bcmbca_hsspi_interrupt, IRQF_SHARED,
|
||||
pdev->name, bs);
|
||||
if (ret)
|
||||
goto out_put_host;
|
||||
goto out_disable_pll_clk;
|
||||
}
|
||||
|
||||
ret = devm_pm_runtime_enable(&pdev->dev);
|
||||
if (ret)
|
||||
goto out_put_host;
|
||||
goto out_disable_pll_clk;
|
||||
|
||||
ret = sysfs_create_group(&pdev->dev.kobj, &bcmbca_hsspi_group);
|
||||
if (ret) {
|
||||
dev_err(&pdev->dev, "couldn't register sysfs group\n");
|
||||
goto out_put_host;
|
||||
goto out_disable_pll_clk;
|
||||
}
|
||||
|
||||
/* register and we are done */
|
||||
@ -560,8 +560,6 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev)
|
||||
|
||||
out_sysgroup_disable:
|
||||
sysfs_remove_group(&pdev->dev.kobj, &bcmbca_hsspi_group);
|
||||
out_put_host:
|
||||
spi_controller_put(host);
|
||||
out_disable_pll_clk:
|
||||
clk_disable_unprepare(pll_clk);
|
||||
out_disable_clk:
|
||||
|
Loading…
Reference in New Issue
Block a user