korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-18 01:34:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

remoteproc: Use a local copy for the name field

Browse Source 
The current name field used in the remoteproc structure is simply
a pointer to a name field supplied during the rproc_alloc() call.
The pointer passed in by remoteproc drivers during registration is
typically a dev_name pointer, but it is possible that the pointer
will no longer remain valid if the devices themselves were created
at runtime like in the case of of_platform_populate(), and were
deleted upon any failures within the respective remoteproc driver
probe function.

So, allocate and maintain a local copy for this name field to
keep it agnostic of the logic used in the remoteproc drivers.

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Suman Anna <s-anna@ti.com>
Link: https://lore.kernel.org/r/20200417002036.24359-3-s-anna@ti.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
Suman Anna 2020-04-16 19:20:36 -05:00 committed by Bjorn Andersson
parent 226f5db421
commit db65527836
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/remoteproc/remoteproc_core.c
View File

@ -1997,6 +1997,7 @@ static void rproc_type_release(struct device *dev)
ida_simple_remove(&rproc_dev_index, rproc->index); ida_simple_remove(&rproc_dev_index, rproc->index);
kfree_const(rproc->firmware); kfree_const(rproc->firmware);
kfree_const(rproc->name);
kfree(rproc->ops); kfree(rproc->ops);
kfree(rproc); kfree(rproc);
} }
@ -2084,7 +2085,6 @@ struct rproc *rproc_alloc(struct device *dev, const char *name,
if (!rproc) if (!rproc)
return NULL; return NULL;
rproc->name = name;
rproc->priv = &rproc[1]; rproc->priv = &rproc[1];
rproc->auto_boot = true; rproc->auto_boot = true;
rproc->elf_class = ELFCLASSNONE; rproc->elf_class = ELFCLASSNONE;
@ -2097,6 +2097,10 @@ struct rproc *rproc_alloc(struct device *dev, const char *name,
rproc->dev.driver_data = rproc; rproc->dev.driver_data = rproc;
idr_init(&rproc->notifyids); idr_init(&rproc->notifyids);
rproc->name = kstrdup_const(name, GFP_KERNEL);
if (!rproc->name)
goto put_device;
if (rproc_alloc_firmware(rproc, name, firmware)) if (rproc_alloc_firmware(rproc, name, firmware))
goto put_device; goto put_device;