mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-09-22 04:31:58 +08:00
perf: arm_smmuv3: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/23bfd1a73ce819ffce6137c237608684a3cdfda6.1702648125.git.u.kleine-koenig@pengutronix.de Signed-off-by: Will Deacon <will@kernel.org>
This commit is contained in:
parent
02d77ac1ac
commit
d67c3a61f0
@ -965,14 +965,12 @@ out_unregister:
|
||||
return err;
|
||||
}
|
||||
|
||||
static int smmu_pmu_remove(struct platform_device *pdev)
|
||||
static void smmu_pmu_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct smmu_pmu *smmu_pmu = platform_get_drvdata(pdev);
|
||||
|
||||
perf_pmu_unregister(&smmu_pmu->pmu);
|
||||
cpuhp_state_remove_instance_nocalls(cpuhp_state_num, &smmu_pmu->node);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void smmu_pmu_shutdown(struct platform_device *pdev)
|
||||
@ -997,7 +995,7 @@ static struct platform_driver smmu_pmu_driver = {
|
||||
.suppress_bind_attrs = true,
|
||||
},
|
||||
.probe = smmu_pmu_probe,
|
||||
.remove = smmu_pmu_remove,
|
||||
.remove_new = smmu_pmu_remove,
|
||||
.shutdown = smmu_pmu_shutdown,
|
||||
};
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user