korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 12:28:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

ext4: notify sysfs on errors_count value change

Browse Source 
After s_error_count is incremented, signal the change in the
corresponding sysfs attribute via sysfs_notify. This allows userspace to
poll() on changes to /sys/fs/ext4/*/errors_count.

[ Moved call of ext4_notify_error_sysfs() to flush_stashed_error_work()
  to avoid BUG's caused by calling sysfs_notify trying to sleep after
  being called from an invalid context. -- TYT ]

Signed-off-by: Jonathan Davies <jonathan.davies@nutanix.com>
Link: https://lore.kernel.org/r/20210611140209.28903-1-jonathan.davies@nutanix.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Jonathan Davies 2021-06-11 14:02:08 +00:00 committed by Theodore Ts'o
parent acc6100d3f
commit d578b99443
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fs/ext4/ext4.h
View File

@ -3624,6 +3624,7 @@ extern const struct inode_operations ext4_symlink_inode_operations;
extern const struct inode_operations ext4_fast_symlink_inode_operations; extern const struct inode_operations ext4_fast_symlink_inode_operations;
/* sysfs.c */ /* sysfs.c */
extern void ext4_notify_error_sysfs(struct ext4_sb_info *sbi);
extern int ext4_register_sysfs(struct super_block *sb); extern int ext4_register_sysfs(struct super_block *sb);
extern void ext4_unregister_sysfs(struct super_block *sb); extern void ext4_unregister_sysfs(struct super_block *sb);
extern int __init ext4_init_sysfs(void); extern int __init ext4_init_sysfs(void);

2
fs/ext4/super.c
View File

@ -718,6 +718,7 @@ static void flush_stashed_error_work(struct work_struct *work)
goto write_directly; goto write_directly;
} }
jbd2_journal_stop(handle); jbd2_journal_stop(handle);
ext4_notify_error_sysfs(sbi);
return; return;
} }
write_directly: write_directly:
@ -726,6 +727,7 @@ write_directly:
* out and hope for the best. * out and hope for the best.
*/ */
ext4_commit_super(sbi->s_sb); ext4_commit_super(sbi->s_sb);
ext4_notify_error_sysfs(sbi);
} }
#define ext4_error_ratelimit(sb) \ #define ext4_error_ratelimit(sb) \

5
fs/ext4/sysfs.c
View File

@ -506,6 +506,11 @@ static struct kobj_type ext4_feat_ktype = {
.release = (void (*)(struct kobject *))kfree, .release = (void (*)(struct kobject *))kfree,
}; };
void ext4_notify_error_sysfs(struct ext4_sb_info *sbi)
{
sysfs_notify(&sbi->s_kobj, NULL, "errors_count");
}
static struct kobject *ext4_root; static struct kobject *ext4_root;
static struct kobject *ext4_feat; static struct kobject *ext4_feat;