korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-26 13:44:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

UBIFS: replace seq_printf by seq_puts

Browse Source 
Fix checkpatch warnings:
"WARNING: Prefer seq_puts to seq_printf"

Andrew Morton wrote:

"
- puts is presumably faster

- puts doesn't go rogue if you accidentally pass it a "%".

- this patch actually made fs/ubifs/super.o 12 bytes smaller.
  Perhaps because seq_printf() is a varargs function, forcing the
  caller to pass args on the stack instead of in registers.
"

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
This commit is contained in:
Fabian Frederick 2014-07-15 21:26:35 +02:00 committed by Artem Bityutskiy
parent 86b4c14de3
commit d4eb08ff0a
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/ubifs/super.c
View File

@ -424,19 +424,19 @@ static int ubifs_show_options(struct seq_file *s, struct dentry *root)
struct ubifs_info *c = root->d_sb->s_fs_info; struct ubifs_info *c = root->d_sb->s_fs_info;
if (c->mount_opts.unmount_mode == 2) if (c->mount_opts.unmount_mode == 2)
seq_printf(s, ",fast_unmount"); seq_puts(s, ",fast_unmount");
else if (c->mount_opts.unmount_mode == 1) else if (c->mount_opts.unmount_mode == 1)
seq_printf(s, ",norm_unmount"); seq_puts(s, ",norm_unmount");
if (c->mount_opts.bulk_read == 2) if (c->mount_opts.bulk_read == 2)
seq_printf(s, ",bulk_read"); seq_puts(s, ",bulk_read");
else if (c->mount_opts.bulk_read == 1) else if (c->mount_opts.bulk_read == 1)
seq_printf(s, ",no_bulk_read"); seq_puts(s, ",no_bulk_read");
if (c->mount_opts.chk_data_crc == 2) if (c->mount_opts.chk_data_crc == 2)
seq_printf(s, ",chk_data_crc"); seq_puts(s, ",chk_data_crc");
else if (c->mount_opts.chk_data_crc == 1) else if (c->mount_opts.chk_data_crc == 1)
seq_printf(s, ",no_chk_data_crc"); seq_puts(s, ",no_chk_data_crc");
if (c->mount_opts.override_compr) { if (c->mount_opts.override_compr) {
seq_printf(s, ",compr=%s", seq_printf(s, ",compr=%s",