mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-27 14:14:24 +08:00
regulator: bd9571mwv: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://msgid.link/r/639e796b36815a219ff1172cc758ba7378211d74.1701778038.git.u.kleine-koenig@pengutronix.de Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
03560ff08d
commit
cddda6f5f4
@ -260,10 +260,9 @@ static const struct dev_pm_ops bd9571mwv_pm = {
|
||||
SET_SYSTEM_SLEEP_PM_OPS(bd9571mwv_suspend, bd9571mwv_resume)
|
||||
};
|
||||
|
||||
static int bd9571mwv_regulator_remove(struct platform_device *pdev)
|
||||
static void bd9571mwv_regulator_remove(struct platform_device *pdev)
|
||||
{
|
||||
device_remove_file(&pdev->dev, &dev_attr_backup_mode);
|
||||
return 0;
|
||||
}
|
||||
#define DEV_PM_OPS &bd9571mwv_pm
|
||||
#else
|
||||
@ -357,7 +356,7 @@ static struct platform_driver bd9571mwv_regulator_driver = {
|
||||
.pm = DEV_PM_OPS,
|
||||
},
|
||||
.probe = bd9571mwv_regulator_probe,
|
||||
.remove = bd9571mwv_regulator_remove,
|
||||
.remove_new = bd9571mwv_regulator_remove,
|
||||
.id_table = bd9571mwv_regulator_id_table,
|
||||
};
|
||||
module_platform_driver(bd9571mwv_regulator_driver);
|
||||
|
Loading…
Reference in New Issue
Block a user