mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-10 12:34:07 +08:00
ASoC: soc-pcm: use goto and remove multi return
When we use some kind of lock, we need to do unlock. In that time, multi unlock/return is not good implementation. This patch add label and use goto at dpcm_fe_dai_open() to reduce such code. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/877e0lboty.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
085d22be03
commit
cae06eb925
@ -2733,8 +2733,7 @@ static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream)
|
|||||||
|
|
||||||
ret = dpcm_path_get(fe, stream, &list);
|
ret = dpcm_path_get(fe, stream, &list);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
mutex_unlock(&fe->card->mutex);
|
goto open_end;
|
||||||
return ret;
|
|
||||||
} else if (ret == 0) {
|
} else if (ret == 0) {
|
||||||
dev_dbg(fe->dev, "ASoC: %s no valid %s route\n",
|
dev_dbg(fe->dev, "ASoC: %s no valid %s route\n",
|
||||||
fe->dai_link->name, stream ? "capture" : "playback");
|
fe->dai_link->name, stream ? "capture" : "playback");
|
||||||
@ -2755,6 +2754,7 @@ static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream)
|
|||||||
|
|
||||||
dpcm_clear_pending_state(fe, stream);
|
dpcm_clear_pending_state(fe, stream);
|
||||||
dpcm_path_put(&list);
|
dpcm_path_put(&list);
|
||||||
|
open_end:
|
||||||
mutex_unlock(&fe->card->mutex);
|
mutex_unlock(&fe->card->mutex);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user