korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-24 04:34:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

MIPS: vpe-cmp: fix possible memory leak while module exiting

Browse Source 
dev_set_name() allocates memory for name, it need be freed
when module exiting, call put_device() to give up reference,
so that it can be freed in kobject_cleanup() when the refcount
hit to 0. The vpe_device is static, so remove kfree() from
vpe_device_release().

Fixes: 17a1d523aa ("MIPS: APRP: Add VPE loader support for CMP platforms.")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
Yang Yingliang 2022-11-04 11:39:45 +08:00 committed by Thomas Bogendoerfer
parent 5822e8cc84
commit c5ed1fe080
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/mips/kernel/vpe-cmp.c
View File

@ -75,7 +75,6 @@ ATTRIBUTE_GROUPS(vpe);
static void vpe_device_release(struct device *cd) static void vpe_device_release(struct device *cd)
{ {
kfree(cd);
} }
static struct class vpe_class = { static struct class vpe_class = {
@ -157,6 +156,7 @@ out_dev:
device_del(&vpe_device); device_del(&vpe_device);
out_class: out_class:
put_device(&vpe_device);
class_unregister(&vpe_class); class_unregister(&vpe_class);
out_chrdev: out_chrdev:
@ -169,7 +169,7 @@ void __exit vpe_module_exit(void)
{ {
struct vpe *v, *n; struct vpe *v, *n;
device_del(&vpe_device); device_unregister(&vpe_device);
class_unregister(&vpe_class); class_unregister(&vpe_class);
unregister_chrdev(major, VPE_MODULE_NAME); unregister_chrdev(major, VPE_MODULE_NAME);