mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-09-22 04:31:58 +08:00
ALSA: usb-audio: fix use after free in usb_audio_disconnect
The problem was in wrong "if" placement. chip->quirk_type is freed
in snd_card_free_when_closed(), but inside if statement it's accesed.
Fixes: 9799110825
("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/16da19126ff461e5e64a9aec648cce28fb8ed73e.1615242183.git.paskripkin@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
30dea07180
commit
c5aa956eae
@ -907,6 +907,9 @@ static void usb_audio_disconnect(struct usb_interface *intf)
|
||||
}
|
||||
}
|
||||
|
||||
if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND)
|
||||
usb_enable_autosuspend(interface_to_usbdev(intf));
|
||||
|
||||
chip->num_interfaces--;
|
||||
if (chip->num_interfaces <= 0) {
|
||||
usb_chip[chip->index] = NULL;
|
||||
@ -915,9 +918,6 @@ static void usb_audio_disconnect(struct usb_interface *intf)
|
||||
} else {
|
||||
mutex_unlock(®ister_mutex);
|
||||
}
|
||||
|
||||
if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND)
|
||||
usb_enable_autosuspend(interface_to_usbdev(intf));
|
||||
}
|
||||
|
||||
/* lock the shutdown (disconnect) task and autoresume */
|
||||
|
Loading…
Reference in New Issue
Block a user