korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-06 13:55:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

scsi: ufs: Delete ufshcd_read_desc()

Browse Source 
Delete ufshcd_read_desc(). Instead, let caller directly call
ufshcd_read_desc_param().

Link: https://lore.kernel.org/r/20200603091959.27618-3-huobean@gmail.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Bart van Assche <bvanassche@acm.org>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bean Huo 2020-06-03 11:19:56 +02:00 committed by Martin K. Petersen
parent 458a45f526
commit c4607a0945
1 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/scsi/ufs/ufshcd.c
View File

@ -3234,16 +3234,6 @@ out:
return ret; return ret;
} }
static inline int ufshcd_read_desc(struct ufs_hba *hba,
enum desc_idn desc_id,
int desc_index,
void *buf,
u32 size)
{
return ufshcd_read_desc_param(hba, desc_id, desc_index, 0, buf, size);
}
/** /**
* struct uc_string_id - unicode string * struct uc_string_id - unicode string
* *
@ -3291,9 +3281,8 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index,
if (!uc_str) if (!uc_str)
return -ENOMEM; return -ENOMEM;
ret = ufshcd_read_desc(hba, QUERY_DESC_IDN_STRING, ret = ufshcd_read_desc_param(hba, QUERY_DESC_IDN_STRING, desc_index, 0,
desc_index, uc_str, (u8 *)uc_str, QUERY_DESC_MAX_SIZE);
QUERY_DESC_MAX_SIZE);
if (ret < 0) { if (ret < 0) {
dev_err(hba->dev, "Reading String Desc failed after %d retries. err = %d\n", dev_err(hba->dev, "Reading String Desc failed after %d retries. err = %d\n",
QUERY_REQ_RETRIES, ret); QUERY_REQ_RETRIES, ret);
@ -6813,8 +6802,8 @@ static void ufshcd_set_active_icc_lvl(struct ufs_hba *hba)
if (!desc_buf) if (!desc_buf)
return; return;
ret = ufshcd_read_desc(hba, QUERY_DESC_IDN_POWER, 0, ret = ufshcd_read_desc_param(hba, QUERY_DESC_IDN_POWER, 0, 0,
desc_buf, buff_len); desc_buf, buff_len);
if (ret) { if (ret) {
dev_err(hba->dev, dev_err(hba->dev,
"%s: Failed reading power descriptor.len = %d ret = %d", "%s: Failed reading power descriptor.len = %d ret = %d",
@ -7015,8 +7004,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
goto out; goto out;
} }
err = ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, desc_buf, err = ufshcd_read_desc_param(hba, QUERY_DESC_IDN_DEVICE, 0, 0, desc_buf,
hba->desc_size.dev_desc); hba->desc_size.dev_desc);
if (err) { if (err) {
dev_err(hba->dev, "%s: Failed reading Device Desc. err = %d\n", dev_err(hba->dev, "%s: Failed reading Device Desc. err = %d\n",
__func__, err); __func__, err);
@ -7298,8 +7287,8 @@ static int ufshcd_device_geo_params_init(struct ufs_hba *hba)
goto out; goto out;
} }
err = ufshcd_read_desc(hba, QUERY_DESC_IDN_GEOMETRY, 0, err = ufshcd_read_desc_param(hba, QUERY_DESC_IDN_GEOMETRY, 0, 0,
desc_buf, buff_len); desc_buf, buff_len);
if (err) { if (err) {
dev_err(hba->dev, "%s: Failed reading Geometry Desc. err = %d\n", dev_err(hba->dev, "%s: Failed reading Geometry Desc. err = %d\n",
__func__, err); __func__, err);