korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-09-22 12:44:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_prepare_tx()

Browse Source 
It is overkill to crash the kernel if the given message is oversize.

Drop the BUG_ON() and return -EINVAL instead.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220513044143.1045728-4-tzungbi@kernel.org
This commit is contained in:
Tzung-Bi Shih 2022-05-13 12:41:39 +08:00
parent 71d3ae7fb6
commit c2dcb1b060
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/platform/chrome/cros_ec_proto.c
View File

@ -60,7 +60,8 @@ static int prepare_packet(struct cros_ec_device *ec_dev,
int i; int i;
u8 csum = 0; u8 csum = 0;
BUG_ON(msg->outsize + sizeof(*request) > ec_dev->dout_size); if (msg->outsize + sizeof(*request) > ec_dev->dout_size)
return -EINVAL;
out = ec_dev->dout; out = ec_dev->dout;
request = (struct ec_host_request *)out; request = (struct ec_host_request *)out;
@ -176,7 +177,9 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev,
if (ec_dev->proto_version > 2) if (ec_dev->proto_version > 2)
return prepare_packet(ec_dev, msg); return prepare_packet(ec_dev, msg);
BUG_ON(msg->outsize > EC_PROTO2_MAX_PARAM_SIZE); if (msg->outsize > EC_PROTO2_MAX_PARAM_SIZE)
return -EINVAL;
out = ec_dev->dout; out = ec_dev->dout;
out[0] = EC_CMD_VERSION0 + msg->version; out[0] = EC_CMD_VERSION0 + msg->version;
out[1] = msg->command; out[1] = msg->command;