korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-05 10:04:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()

Browse Source 
In the case of a failed retry, a positive value EIO is returned here.  I
think this is a typo error. It is necessary to return an error value.

[mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up
to be consistent]

Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com
Fixes: 0691094ff3 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Tianjia Zhang 2020-08-02 19:15:28 +08:00 committed by Martin K. Petersen
parent 8905cbdae9
commit bbf2d06a9d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/qla2xxx/qla_target.c
View File

@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha,
/* found existing exchange */ /* found existing exchange */
qpair->retry_term_cnt++; qpair->retry_term_cnt++;
if (qpair->retry_term_cnt >= 5) { if (qpair->retry_term_cnt >= 5) {
rc = EIO; rc = -EIO;
qpair->retry_term_cnt = 0; qpair->retry_term_cnt = 0;
ql_log(ql_log_warn, vha, 0xffff, ql_log(ql_log_warn, vha, 0xffff,
"Unable to send ABTS Respond. Dumping firmware.\n"); "Unable to send ABTS Respond. Dumping firmware.\n");