korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-18 11:54:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

uwb: properly check kthread_run return value

Browse Source 
uwbd_start() calls kthread_run() and checks that the return value is
not NULL. But the return value is not NULL in case kthread_run() fails,
it takes the form of ERR_PTR(-EINTR).

Use IS_ERR() instead.

Also add a check to uwbd_stop().

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andrey Konovalov 2017-09-14 14:30:55 +02:00 committed by Greg Kroah-Hartman
parent 70e743e4ce
commit bbf26183b7
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/uwb/uwbd.c
View File

@ -302,17 +302,21 @@ static int uwbd(void *param)
/** Start the UWB daemon */ /** Start the UWB daemon */
void uwbd_start(struct uwb_rc *rc) void uwbd_start(struct uwb_rc *rc)
{ {
rc->uwbd.task = kthread_run(uwbd, rc, "uwbd"); struct task_struct *task = kthread_run(uwbd, rc, "uwbd");
if (rc->uwbd.task == NULL) if (IS_ERR(task)) {
rc->uwbd.task = NULL;
printk(KERN_ERR "UWB: Cannot start management daemon; " printk(KERN_ERR "UWB: Cannot start management daemon; "
"UWB won't work\n"); "UWB won't work\n");
else } else {
rc->uwbd.task = task;
rc->uwbd.pid = rc->uwbd.task->pid; rc->uwbd.pid = rc->uwbd.task->pid;
}
} }
/* Stop the UWB daemon and free any unprocessed events */ /* Stop the UWB daemon and free any unprocessed events */
void uwbd_stop(struct uwb_rc *rc) void uwbd_stop(struct uwb_rc *rc)
{ {
if (rc->uwbd.task)
kthread_stop(rc->uwbd.task); kthread_stop(rc->uwbd.task);
uwbd_flush(rc); uwbd_flush(rc);
} }