korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-18 09:44:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

asus-wmi: fix error handling in store_sys_wmi()

Browse Source 
The asus_wmi_get_devstate_simple() returns 0-1 on success.  In theory
according to static checkers, it can return either -EIO or -ENODEV on
failure.  Currently the error handling code only handles -ENODEV and
-EIO is treated as success.  Let's make it handle the -EIO error as
well.

It's possible that it can't actually return -EIO and this patch is not
needed but in that case this patch is harmless and silences a static
checker warning so it's still worth it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
This commit is contained in:
Dan Carpenter 2015-11-11 01:18:16 +03:00 committed by Darren Hart
parent f71c882dd4
commit b829834016
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/platform/x86/asus-wmi.c
View File

@ -1682,7 +1682,7 @@ static ssize_t store_sys_wmi(struct asus_wmi *asus, int devid,
int rv, err, value; int rv, err, value;
value = asus_wmi_get_devstate_simple(asus, devid); value = asus_wmi_get_devstate_simple(asus, devid);
if (value == -ENODEV) /* Check device presence */ if (value < 0)
return value; return value;
rv = parse_arg(buf, count, &value); rv = parse_arg(buf, count, &value);