korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-28 14:44:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

phy: rockchip: phy-rockchip-inno-csidphy: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-20-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-07 12:58:48 +01:00 committed by Vinod Koul
parent f1c01b91e5
commit b41f07b201
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c
View File

@ -459,13 +459,11 @@ static int rockchip_inno_csidphy_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int rockchip_inno_csidphy_remove(struct platform_device *pdev) static void rockchip_inno_csidphy_remove(struct platform_device *pdev)
{ {
struct rockchip_inno_csidphy *priv = platform_get_drvdata(pdev); struct rockchip_inno_csidphy *priv = platform_get_drvdata(pdev);
pm_runtime_disable(priv->dev); pm_runtime_disable(priv->dev);
return 0;
} }
static struct platform_driver rockchip_inno_csidphy_driver = { static struct platform_driver rockchip_inno_csidphy_driver = {
@ -474,7 +472,7 @@ static struct platform_driver rockchip_inno_csidphy_driver = {
.of_match_table = rockchip_inno_csidphy_match_id, .of_match_table = rockchip_inno_csidphy_match_id,
}, },
.probe = rockchip_inno_csidphy_probe, .probe = rockchip_inno_csidphy_probe,
.remove = rockchip_inno_csidphy_remove, .remove_new = rockchip_inno_csidphy_remove,
}; };
module_platform_driver(rockchip_inno_csidphy_driver); module_platform_driver(rockchip_inno_csidphy_driver);