korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-20 02:34:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf/x86/intel: Add lockdep assert

Browse Source 
Lockdep is very good at finding incorrect IRQ state while locking and
is far better at telling us if we hold a lock than the _is_locked()
API. It also generates less code for !DEBUG kernels.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Peter Zijlstra 2015-05-21 12:38:21 +02:00 committed by Ingo Molnar
parent 1c565833ac
commit b32ed7f5de
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/x86/kernel/cpu/perf_event_intel.c
View File

@ -1926,7 +1926,6 @@ intel_start_scheduling(struct cpu_hw_events *cpuc)
* in stop_event_scheduling() * in stop_event_scheduling()
* makes scheduling appear as a transaction * makes scheduling appear as a transaction
*/ */
WARN_ON_ONCE(!irqs_disabled());
raw_spin_lock(&excl_cntrs->lock); raw_spin_lock(&excl_cntrs->lock);
/* /*
@ -2208,7 +2207,7 @@ static void intel_commit_scheduling(struct cpu_hw_events *cpuc, int idx, int cnt
xl = &excl_cntrs->states[tid]; xl = &excl_cntrs->states[tid];
WARN_ON_ONCE(!raw_spin_is_locked(&excl_cntrs->lock)); lockdep_assert_held(&excl_cntrs->lock);
if (cntr >= 0) { if (cntr >= 0) {
if (c->flags & PERF_X86_EVENT_EXCL) if (c->flags & PERF_X86_EVENT_EXCL)