korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-04 17:44:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

gpu: ipu-v3: wait_for_completion_timeout does not return negative status

Browse Source 
This fixes up the return value handling and the return type.

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
Nicholas Mc Guire 2015-01-19 12:38:11 +01:00 committed by Philipp Zabel
parent 5159571ceb
commit af7537d3c8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/ipu-v3/ipu-dc.c
View File

@ -267,7 +267,8 @@ static irqreturn_t dc_irq_handler(int irq, void *dev_id)
void ipu_dc_disable_channel(struct ipu_dc *dc) void ipu_dc_disable_channel(struct ipu_dc *dc)
{ {
struct ipu_dc_priv *priv = dc->priv; struct ipu_dc_priv *priv = dc->priv;
int irq, ret; int irq;
unsigned long ret;
u32 val; u32 val;
/* TODO: Handle MEM_FG_SYNC differently from MEM_BG_SYNC */ /* TODO: Handle MEM_FG_SYNC differently from MEM_BG_SYNC */
@ -282,7 +283,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
enable_irq(irq); enable_irq(irq);
ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50)); ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
disable_irq(irq); disable_irq(irq);
if (ret <= 0) { if (ret == 0) {
dev_warn(priv->dev, "DC stop timeout after 50 ms\n"); dev_warn(priv->dev, "DC stop timeout after 50 ms\n");
val = readl(dc->base + DC_WR_CH_CONF); val = readl(dc->base + DC_WR_CH_CONF);