korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-28 05:24:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

ksmbd: prevent memory leak on error return

Browse Source 
[ Upstream commit 90044481e7 ]

When allocated memory for 'new' failed,just return
will cause memory leak of 'ar'.

Fixes: 1819a90429 ("ksmbd: reorganize ksmbd_iov_pin_rsp()")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202311031837.H3yo7JVl-lkp@intel.com/
Signed-off-by: Zongmin Zhou<zhouzongmin@kylinos.cn>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zongmin Zhou 2023-12-19 00:34:48 +09:00 committed by Greg Kroah-Hartman
parent 8dc9eb7d35
commit ae3356cbe9
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/ksmbd/ksmbd_work.c
View File

@ -106,7 +106,7 @@ static inline void __ksmbd_iov_pin(struct ksmbd_work *work, void *ib,
static int __ksmbd_iov_pin_rsp(struct ksmbd_work *work, void *ib, int len, static int __ksmbd_iov_pin_rsp(struct ksmbd_work *work, void *ib, int len,
void *aux_buf, unsigned int aux_size) void *aux_buf, unsigned int aux_size)
{ {
struct aux_read *ar; struct aux_read *ar = NULL;
int need_iov_cnt = 1; int need_iov_cnt = 1;
if (aux_size) { if (aux_size) {
@ -123,8 +123,11 @@ static int __ksmbd_iov_pin_rsp(struct ksmbd_work *work, void *ib, int len,
new = krealloc(work->iov, new = krealloc(work->iov,
sizeof(struct kvec) * work->iov_alloc_cnt, sizeof(struct kvec) * work->iov_alloc_cnt,
GFP_KERNEL | __GFP_ZERO); GFP_KERNEL | __GFP_ZERO);
if (!new) if (!new) {
kfree(ar);
work->iov_alloc_cnt -= 4;
return -ENOMEM; return -ENOMEM;
}
work->iov = new; work->iov = new;
} }