mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-09-22 22:11:38 +08:00
net: hns3: fix dereference of ae_dev before it is null checked
Pointer ae_dev is null checked however, prior to that it is dereferenced when assigned pointer ops. Fix this by assigning pointer ops after ae_dev has been null checked. Addresses-Coverity: ("Dereference before null check") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
43321251e2
commit
ad9bf54519
@ -1940,13 +1940,14 @@ static pci_ers_result_t hns3_error_detected(struct pci_dev *pdev,
|
|||||||
static pci_ers_result_t hns3_slot_reset(struct pci_dev *pdev)
|
static pci_ers_result_t hns3_slot_reset(struct pci_dev *pdev)
|
||||||
{
|
{
|
||||||
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
|
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
|
||||||
const struct hnae3_ae_ops *ops = ae_dev->ops;
|
const struct hnae3_ae_ops *ops;
|
||||||
enum hnae3_reset_type reset_type;
|
enum hnae3_reset_type reset_type;
|
||||||
struct device *dev = &pdev->dev;
|
struct device *dev = &pdev->dev;
|
||||||
|
|
||||||
if (!ae_dev || !ae_dev->ops)
|
if (!ae_dev || !ae_dev->ops)
|
||||||
return PCI_ERS_RESULT_NONE;
|
return PCI_ERS_RESULT_NONE;
|
||||||
|
|
||||||
|
ops = ae_dev->ops;
|
||||||
/* request the reset */
|
/* request the reset */
|
||||||
if (ops->reset_event) {
|
if (ops->reset_event) {
|
||||||
if (!ae_dev->override_pci_need_reset) {
|
if (!ae_dev->override_pci_need_reset) {
|
||||||
|
Loading…
Reference in New Issue
Block a user