mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 04:18:39 +08:00
rtc: asm9260: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230304133028.2135435-6-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
parent
28015e799a
commit
ad01bf83bf
@ -308,14 +308,13 @@ err_return:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int asm9260_rtc_remove(struct platform_device *pdev)
|
||||
static void asm9260_rtc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct asm9260_rtc_priv *priv = platform_get_drvdata(pdev);
|
||||
|
||||
/* Disable alarm matching */
|
||||
iowrite32(BM_AMR_OFF, priv->iobase + HW_AMR);
|
||||
clk_disable_unprepare(priv->clk);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id asm9260_dt_ids[] = {
|
||||
@ -326,7 +325,7 @@ MODULE_DEVICE_TABLE(of, asm9260_dt_ids);
|
||||
|
||||
static struct platform_driver asm9260_rtc_driver = {
|
||||
.probe = asm9260_rtc_probe,
|
||||
.remove = asm9260_rtc_remove,
|
||||
.remove_new = asm9260_rtc_remove,
|
||||
.driver = {
|
||||
.name = "asm9260-rtc",
|
||||
.of_match_table = asm9260_dt_ids,
|
||||
|
Loading…
Reference in New Issue
Block a user