korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-26 21:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Input: applespi - fix warnings detected by sparse

Browse Source 
This makes sure that we convert from on-wire to CPU endianness in
applespi_debug_update_dimensions() and also marks as "static" as it is not
needed to be visible outside of the driver.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Ronald Tschalär 2019-07-21 15:15:12 +03:00 committed by Dmitry Torokhov
parent c39f2d9db0
commit a7cd67e2b7
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/input/keyboard/applespi.c
View File

@ -944,10 +944,14 @@ static inline int le16_to_int(__le16 x)
static void applespi_debug_update_dimensions(struct applespi_data *applespi,
const struct tp_finger *f)
{
applespi->tp_dim_min_x = min_t(int, applespi->tp_dim_min_x, f->abs_x);
applespi->tp_dim_max_x = max_t(int, applespi->tp_dim_max_x, f->abs_x);
applespi->tp_dim_min_y = min_t(int, applespi->tp_dim_min_y, f->abs_y);
applespi->tp_dim_max_y = max_t(int, applespi->tp_dim_max_y, f->abs_y);
applespi->tp_dim_min_x = min(applespi->tp_dim_min_x,
le16_to_int(f->abs_x));
applespi->tp_dim_max_x = max(applespi->tp_dim_max_x,
le16_to_int(f->abs_x));
applespi->tp_dim_min_y = min(applespi->tp_dim_min_y,
le16_to_int(f->abs_y));
applespi->tp_dim_max_y = max(applespi->tp_dim_max_y,
le16_to_int(f->abs_y));
}
static int applespi_tp_dim_open(struct inode *inode, struct file *file)
@ -1611,8 +1615,8 @@ static void applespi_save_bl_level(struct applespi_data *applespi,
efi_attr = EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS |
EFI_VARIABLE_RUNTIME_ACCESS;
sts = efivar_entry_set_safe(EFI_BL_LEVEL_NAME, efi_guid, efi_attr, true,
efi_data_len, &efi_data);
sts = efivar_entry_set_safe((efi_char16_t *)EFI_BL_LEVEL_NAME, efi_guid,
efi_attr, true, efi_data_len, &efi_data);
if (sts)
dev_warn(&applespi->spi->dev,
"Error saving backlight level to EFI vars: %d\n", sts);
@ -1953,7 +1957,7 @@ static const struct acpi_device_id applespi_acpi_match[] = {
};
MODULE_DEVICE_TABLE(acpi, applespi_acpi_match);
const struct dev_pm_ops applespi_pm_ops = {
static const struct dev_pm_ops applespi_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(applespi_suspend, applespi_resume)
.poweroff_late = applespi_poweroff_late,
};