mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 12:28:41 +08:00
pch_phub: return -ENODATA if ROM can't be mapped
The error return err is not initialized for the case when pci_map_rom fails and no ROM can me mapped. Fix this by setting ret to -ENODATA; (this is the same error value that is returned if the ROM data is successfully mapped but does not match the expected ROM signature.). Issue found from static code analysis using CoverityScan. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
7268644734
commit
a75fa12823
@ -513,8 +513,10 @@ static ssize_t pch_phub_bin_read(struct file *filp, struct kobject *kobj,
|
||||
|
||||
/* Get Rom signature */
|
||||
chip->pch_phub_extrom_base_address = pci_map_rom(chip->pdev, &rom_size);
|
||||
if (!chip->pch_phub_extrom_base_address)
|
||||
if (!chip->pch_phub_extrom_base_address) {
|
||||
err = -ENODATA;
|
||||
goto exrom_map_err;
|
||||
}
|
||||
|
||||
pch_phub_read_serial_rom(chip, chip->pch_opt_rom_start_address,
|
||||
(unsigned char *)&rom_signature);
|
||||
|
Loading…
Reference in New Issue
Block a user