korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-02 16:44:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

dma-mapping: benchmark: use u8 for reserved field in uAPI structure

Browse Source 
The original code put five u32 before a u64 expansion[10] array. Five is
odd, this will cause trouble in the extension of the structure by adding
new features. This patch moves to use u8 for reserved field to avoid
future alignment risk.
Meanwhile, it also clears the memory of struct map_benchmark in tools,
otherwise, if users use old version to run on newer kernel, the random
expansion value will cause side effect on newer kernel.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Barry Song 2021-02-06 00:33:24 +13:00 committed by Christoph Hellwig
parent dd86e7fa07
commit 9f5f8ec501
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/dma/map_benchmark.c
View File

@ -36,7 +36,7 @@ struct map_benchmark {
__s32 node; /* which numa node this benchmark will run on */ __s32 node; /* which numa node this benchmark will run on */
__u32 dma_bits; /* DMA addressing capability */ __u32 dma_bits; /* DMA addressing capability */
__u32 dma_dir; /* DMA data direction */ __u32 dma_dir; /* DMA data direction */
__u64 expansion[10]; /* For future use */ __u8 expansion[84]; /* For future use */
}; };
struct map_benchmark_data { struct map_benchmark_data {

4
tools/testing/selftests/dma/dma_map_benchmark.c
View File

@ -6,6 +6,7 @@
#include <fcntl.h> #include <fcntl.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h>
#include <unistd.h> #include <unistd.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/mman.h> #include <sys/mman.h>
@ -35,7 +36,7 @@ struct map_benchmark {
__s32 node; /* which numa node this benchmark will run on */ __s32 node; /* which numa node this benchmark will run on */
__u32 dma_bits; /* DMA addressing capability */ __u32 dma_bits; /* DMA addressing capability */
__u32 dma_dir; /* DMA data direction */ __u32 dma_dir; /* DMA data direction */
__u64 expansion[10]; /* For future use */ __u8 expansion[84]; /* For future use */
}; };
int main(int argc, char **argv) int main(int argc, char **argv)
@ -102,6 +103,7 @@ int main(int argc, char **argv)
exit(1); exit(1);
} }
memset(&map, 0, sizeof(map));
map.seconds = seconds; map.seconds = seconds;
map.threads = threads; map.threads = threads;
map.node = node; map.node = node;