korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-06 05:44:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

nfp: Prefer struct_size over open coded arithmetic

Browse Source 
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + count * size" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Len Baker 2021-09-12 15:10:57 +02:00 committed by David S. Miller
parent f55e36d5ab
commit 9eb4c320be
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
View File

@ -499,8 +499,7 @@ struct nfp_reprs *nfp_reprs_alloc(unsigned int num_reprs)
{ {
struct nfp_reprs *reprs; struct nfp_reprs *reprs;
reprs = kzalloc(sizeof(*reprs) + reprs = kzalloc(struct_size(reprs, reprs, num_reprs), GFP_KERNEL);
num_reprs * sizeof(struct net_device *), GFP_KERNEL);
if (!reprs) if (!reprs)
return NULL; return NULL;
reprs->num_reprs = num_reprs; reprs->num_reprs = num_reprs;