mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-06 02:24:14 +08:00
mmc: toshsd: move dereference below check for NULL
We check for NULL pointers after dereferencing so it's too late. Oddly enough, Smatch misses this code but complains about the caller passing NULL pointers to this function: drivers/mmc/host/toshsd.c:389 toshsd_irq() error: we previously assumed 'host->cmd' could be null (see line 349) Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
parent
ecb89f2f5f
commit
9e2a0c96ef
@ -206,14 +206,14 @@ static irqreturn_t toshsd_thread_irq(int irq, void *dev_id)
|
||||
static void toshsd_cmd_irq(struct toshsd_host *host)
|
||||
{
|
||||
struct mmc_command *cmd = host->cmd;
|
||||
u8 *buf = (u8 *) cmd->resp;
|
||||
u8 *buf;
|
||||
u16 data;
|
||||
|
||||
if (!host->cmd) {
|
||||
dev_warn(&host->pdev->dev, "Spurious CMD irq\n");
|
||||
return;
|
||||
}
|
||||
|
||||
buf = (u8 *)cmd->resp;
|
||||
host->cmd = NULL;
|
||||
|
||||
if (cmd->flags & MMC_RSP_PRESENT && cmd->flags & MMC_RSP_136) {
|
||||
|
Loading…
Reference in New Issue
Block a user