korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-15 00:04:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy()

Browse Source 
The second parameter of spinlock_irq[save/restore] function is flags,
which is the last input parameter of sf_pdma_prep_dma_memcpy().

So declare local variable 'iflags' to be used as the second parameter of
spinlock_irq[save/restore] function.

Signed-off-by: Austin Kim <austin.kim@lge.com>
Link: https://lore.kernel.org/r/20210611065336.GA1121@raspberrypi
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Austin Kim 2021-06-11 07:53:36 +01:00 committed by Vinod Koul
parent c1fc3745e7
commit 94b4cd7c5f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/dma/sf-pdma/sf-pdma.c
View File

@ -94,6 +94,7 @@ sf_pdma_prep_dma_memcpy(struct dma_chan *dchan, dma_addr_t dest, dma_addr_t src,
{ {
struct sf_pdma_chan *chan = to_sf_pdma_chan(dchan); struct sf_pdma_chan *chan = to_sf_pdma_chan(dchan);
struct sf_pdma_desc *desc; struct sf_pdma_desc *desc;
unsigned long iflags;
if (chan && (!len || !dest || !src)) { if (chan && (!len || !dest || !src)) {
dev_err(chan->pdma->dma_dev.dev, dev_err(chan->pdma->dma_dev.dev,
@ -109,10 +110,10 @@ sf_pdma_prep_dma_memcpy(struct dma_chan *dchan, dma_addr_t dest, dma_addr_t src,
desc->dirn = DMA_MEM_TO_MEM; desc->dirn = DMA_MEM_TO_MEM;
desc->async_tx = vchan_tx_prep(&chan->vchan, &desc->vdesc, flags); desc->async_tx = vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);
spin_lock_irqsave(&chan->vchan.lock, flags); spin_lock_irqsave(&chan->vchan.lock, iflags);
chan->desc = desc; chan->desc = desc;
sf_pdma_fill_desc(desc, dest, src, len); sf_pdma_fill_desc(desc, dest, src, len);
spin_unlock_irqrestore(&chan->vchan.lock, flags); spin_unlock_irqrestore(&chan->vchan.lock, iflags);
return desc->async_tx; return desc->async_tx;
} }